New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-17063 .NET: Improve Java detection on Linux #10069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
public class ShellTests | ||
{ | ||
/// <summary> | ||
/// Tests <see cref="Shell.ExecuteSafe"/> method. | ||
/// </summary> | ||
[Test] | ||
public void TestExecuteSafe() | ||
public void TestExecuteSafeReturnsStdout() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "ReturnsStdout" mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means that ExecuteSafe
method returns whatever the executed command writes to Standard output (stdout) as a string.
/usr/bin/readlink
as well asreadlink
- it is not in PATH in some rare scenarios.