Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-15759 Remove LOCAL caches #10157

Merged
merged 48 commits into from Aug 11, 2022
Merged

IGNITE-15759 Remove LOCAL caches #10157

merged 48 commits into from Aug 11, 2022

Conversation

Mmuzaf
Copy link
Contributor

@Mmuzaf Mmuzaf commented Jul 13, 2022

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

Mmuzaf added 30 commits July 13, 2022 16:38
zstan
zstan approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@zstan zstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fix my issues, overall looks good.

...test/java/org/apache/ignite/internal/client/integration/ClientAbstractMultiNodeSelfTest.java Outdated Show resolved Hide resolved
...core/src/main/java/org/apache/ignite/internal/processors/affinity/LocalAffinityFunction.java Outdated Show resolved Hide resolved
...e/src/test/java/org/apache/ignite/internal/processors/cache/CacheStopAndDestroySelfTest.java Show resolved Hide resolved
anton-vinogradov
anton-vinogradov reviewed Aug 10, 2022
View reviewed changes
modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBatchUpdateTask.java Show resolved Hide resolved
...rg/apache/ignite/internal/processors/cache/datastructures/IgniteDataStructuresTestUtils.java Show resolved Hide resolved
...g/apache/ignite/internal/processors/cache/distributed/IgniteAbstractTxSuspendResumeTest.java Show resolved Hide resolved
...gnite/internal/processors/cache/eviction/paged/PageEvictionPagesRecyclingAndReusingTest.java Show resolved Hide resolved
.../org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionReadThroughTest.java Show resolved Hide resolved
...a/org/apache/ignite/internal/processors/cache/GridCacheConfigurationConsistencySelfTest.java Show resolved Hide resolved
.../test/java/org/apache/ignite/internal/processors/cache/GridCacheOnCopyFlagLocalSelfTest.java Show resolved Hide resolved
.../core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheSlowTxWarnTest.java Outdated Show resolved Hide resolved
modules/core/src/test/java/org/apache/ignite/testframework/MvccFeatureChecker.java Show resolved Hide resolved
...c/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapIndexScanTest.java Outdated Show resolved Hide resolved
@Mmuzaf
Copy link
Contributor Author

Mmuzaf commented Aug 11, 2022

@zstan @anton-vinogradov @isapego @ptupitsyn @NSAmelchev

Folks, I've fixed all your comments. Please, take a final look.

anton-vinogradov
anton-vinogradov approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@anton-vinogradov anton-vinogradov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please gain explicit approve on platform integration (enum).

ptupitsyn
ptupitsyn approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@ptupitsyn ptupitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thin client and .NET changes look good to me.

@Mmuzaf Mmuzaf merged commit 01a7d07 into apache:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zstan zstan zstan approved these changes

@anton-vinogradov anton-vinogradov anton-vinogradov approved these changes

@isapego isapego isapego approved these changes

@ptupitsyn ptupitsyn ptupitsyn approved these changes

@NSAmelchev NSAmelchev NSAmelchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Mmuzaf @zstan @anton-vinogradov @isapego @ptupitsyn @NSAmelchev