IGNITE-18232 Remove of CacheMetricsMXBean legacy JMX bean #10485
Conversation
…not_casted_implicitly
…gument_is_not_casted_implicitly' into IGNITE-15003-calcite-Function_argument_is_not_casted_implicitly
…gument_is_not_casted_implicitly' into IGNITE-15003-calcite-Function_argument_is_not_casted_implicitly # Conflicts: # modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/RexImpTable.java # modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/IgniteSqlValidator.java # modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/DataTypesTest.java
…not_casted_implicitly
…not_casted_implicitly
|
Can we keep one of |
JCache's interfaces are smaller, contain fewer methods. JCache's |
|
Yes. We should cleanup existing MXBeans and keep only methods required by JCache specification. |
It is done in the new beans |
|
We don't need to copy code from existing to those new classes. Please, revert removal of existing JMX class and keep required methods in it. |
Done. I keep CacheClusterMetricsMXBeanImpl. But I think we violate S principle of SOLID. CacheStatisticsMXBean and CacheMXBean should be split and created separately on demand. The old beans implements the both interfaces. However, we pass JCache spec tests |
| */ | ||
| public class CacheClusterMetricsMXBeanImpl implements CacheMetricsMXBean { | ||
| public class CacheClusterMetricsMXBeanImpl implements CacheStatisticsMXBean, CacheMXBean { |
There was a problem hiding this comment.
It this bean still provide cluster-wide values?
There was a problem hiding this comment.
Yes. It uses IgniteCache#metrics(). There is also IgniteCache#localMetrics()
...s/src/test/java/org/apache/ignite/internal/processors/rest/RestMemcacheProtocolSelfTest.java
Show resolved
Hide resolved
nizhikov
changed the title
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.