Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-5910 Method stopGrid(name) doesn't work in multiJvm mode #2382

Closed
wants to merge 10 commits into from
Closed

IGNITE-5910 Method stopGrid(name) doesn't work in multiJvm mode #2382

wants to merge 10 commits into from

Conversation

daradurvs
Copy link
Member

No description provided.

@daradurvs daradurvs force-pushed the ignite-5910 branch 2 times, most recently from 4982dba to 4a9c38e Compare August 6, 2017 08:24
@daradurvs daradurvs force-pushed the ignite-5910 branch 3 times, most recently from a6d513a to 001f22e Compare February 20, 2018 16:41
SomeFire
SomeFire reviewed Feb 20, 2018
View reviewed changes
...s/core/src/test/java/org/apache/ignite/testframework/junits/multijvm/IgniteProcessProxy.java Outdated
proxy.remoteCompute().runAsync(new StopGridTask(igniteInstanceName, cancel));

try {
assert rmtNodeStoppedLatch.await(NODE_LEFT_TIMEOUT, TimeUnit.MILLISECONDS) : "Remote node has not stopped [id=" + rmNodeId + ']';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too long string.

SomeFire
SomeFire reviewed Feb 20, 2018
View reviewed changes
...s/core/src/test/java/org/apache/ignite/testframework/junits/multijvm/IgniteProcessProxy.java Outdated
@@ -295,10 +300,32 @@ public static IgniteProcessProxy ignite(String igniteInstanceName) {
* @param cancel If {@code true} then all jobs currently will be cancelled.
*/
public static void stop(String igniteInstanceName, boolean cancel) {
IgniteProcessProxy proxy = gridProxies.get(igniteInstanceName);
final IgniteProcessProxy proxy = gridProxies.get(igniteInstanceName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need final in Java8.

dspavlov
dspavlov reviewed Mar 15, 2018
View reviewed changes
...s/core/src/test/java/org/apache/ignite/testframework/junits/multijvm/IgniteProcessProxy.java Outdated
proxy.remoteCompute().runAsync(new StopGridTask(igniteInstanceName, cancel));

try {
assert rmtNodeStoppedLatch.await(NODE_LEFT_TIMEOUT, TimeUnit.MILLISECONDS) : "Remote node has not " +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix here, assertion has side effect. If assertions disabled, nothign will be awaited.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure since this is the common construction which is used in the whole testing framework?
If assertions are disabled then the huge part of the testing framework will not be able to work properly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm sure. We consider assertions from JUnit as best practice

Copy link
Member Author

@daradurvs daradurvs Mar 15, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you talking about JUnit 3 assertions from GridAbstactTest? They are not available here since this is not testing class.
I only able to use this construction:
if (rmtNodeStoppedLatch.await(NODE_LEFT_TIMEOUT, TimeUnit.MILLISECONDS)) throw new AssertException("Remote node has not stopped [id=" + rmNodeId + ']');

@daradurvs daradurvs force-pushed the ignite-5910 branch 2 times, most recently from 3e44454 to a9beb00 Compare March 20, 2018 14:15
@asfgit asfgit closed this in 5ccb548 Mar 22, 2018
@daradurvs daradurvs deleted the ignite-5910 branch March 22, 2018 14:25
tonyschak pushed a commit to tonyschak/ignite that referenced this pull request Mar 27, 2018
Merge branch 'master-up' into IGNITE-7090-1
6e713ec 
* master-up: (24 commits)
  IGNITE-7928: .NET: Fixed hang caused by mishandled exception during custom cache store deserialization. This closes apache#3690.
  IGNITE-8036 MulticastIpFinder is replaced with VmIpFinder - Fixes apache#3693.
  ignite-8004 move setting compatibilityMode to head of collectGridNodeData - Fixes apache#3665.
  IGNITE-7852: ODBC: Implemented username/password authentication. This closes apache#3671.
  IGNITE-7969 Wrong 'wait for topology version' routine fixed
  IGNITE-7581 TxPessimisticDeadlockDetectionTest.testDeadlocksLocal hangs on TC - Fixes apache#3654.
  Revert "IGNITE-7436: Added AuthenticationEnabled flag to .NET."
  master Fixed typo.
  IGNITE-7436: Added AuthenticationEnabled flag to .NET.
  IGNITE-7814 wrap on h2database for overwrite Export-Package - Fixes apache#3572.
  IGNITE-7119 Web Agent: Implemented support for comma-separated list of node URIs.
  IGNITE-8002 REST: Added support of new authentication via new API.
  IGNITE-8007 We should treat as empty any partition as empty if it doesn't have any data - Fixes apache#3677.
  IGNITE-5357 Replicated cache reads load balancing.
  IGNITE-5910: Method stopGrid(name) doesn't work in multiJvm mode - Fixes apache#2382.
  �IGNITE-5357 Replicated cache reads load balancing. - Fixes apache#3578.
  IGNITE-4447: Remove "Ignite 150 Clients" suite. - Fixes apache#3204.
  IGNITE-7436: Simple username/password authentication. This closes apache#3483.
  Ignite-7950: Updated benchmarks according to new sql streamer impl.
  IGNITE-7949 Web Console: Refactored post validation on Sign in / Sign up.
  ...
homich1991 pushed a commit to homich1991/ignite that referenced this pull request Mar 27, 2018
@daradurvs @homich1991
IGNITE-5910: Method stopGrid(name) doesn't work in multiJvm mode - Fixes
bfc09a8 
 apache#2382.

Signed-off-by: Nikolay Izhikov <nizhikov@apache.org>
AMashenkov pushed a commit to gridgain/apache-ignite that referenced this pull request Apr 25, 2018
@daradurvs @AMashenkov
IGNITE-5910: Method stopGrid(name) doesn't work in multiJvm mode - Fixes
4e0fe5d 
 apache#2382.

Signed-off-by: Nikolay Izhikov <nizhikov@apache.org>

(cherry picked from commit 5ccb548)
AMashenkov pushed a commit to gridgain/apache-ignite that referenced this pull request Apr 25, 2018
@daradurvs @AMashenkov
IGNITE-5910: Method stopGrid(name) doesn't work in multiJvm mode - Fixes
49dc34b 
 apache#2382.

Signed-off-by: Nikolay Izhikov <nizhikov@apache.org>

(cherry picked from commit 5ccb548)
AMashenkov pushed a commit to gridgain/apache-ignite that referenced this pull request Apr 25, 2018
@daradurvs @AMashenkov
IGNITE-5910: Method stopGrid(name) doesn't work in multiJvm mode - Fixes
197ff2f 
 apache#2382.

Signed-off-by: Nikolay Izhikov <nizhikov@apache.org>

(cherry picked from commit 5ccb548)
AMashenkov pushed a commit to gridgain/apache-ignite that referenced this pull request Apr 25, 2018
@daradurvs @AMashenkov
IGNITE-5910: Method stopGrid(name) doesn't work in multiJvm mode - Fixes
f8249e9 
 apache#2382.

Signed-off-by: Nikolay Izhikov <nizhikov@apache.org>

(cherry picked from commit 5ccb548)
AMashenkov added a commit to gridgain/apache-ignite that referenced this pull request Apr 26, 2018
@AMashenkov
IGNITE-5910: Method stopGrid(name) doesn't work in multiJvm mode - Fixes
84bc16e 
 apache#2382.

Signed-off-by: Nikolay Izhikov <nizhikov@apache.org>

(cherry picked from commit 5ccb548)
AMashenkov added a commit to gridgain/apache-ignite that referenced this pull request Apr 26, 2018
@AMashenkov
IGNITE-5910: Method stopGrid(name) doesn't work in multiJvm mode - Fixes
552dfb7 
 apache#2382.

Signed-off-by: Nikolay Izhikov <nizhikov@apache.org>

(cherry picked from commit 5ccb548)
vldpyatkov pushed a commit to gridgain/apache-ignite that referenced this pull request May 16, 2022
@korlov42
GG-34892 Drop an old index on the index rebuild (apache#2382)
dfa0d28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomeFire SomeFire SomeFire left review comments

@dspavlov dspavlov dspavlov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daradurvs @SomeFire @dspavlov