IGNITE-5852 #2809
Closed
IGNITE-5852 #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdShangGG
reviewed
Oct 6, 2017
|
|
||
| assert assignment != null; | ||
|
|
||
| idealAssignment = assignment; | ||
|
|
||
| baselineTopology = discoCache.state().baselineTopology(); | ||
|
|
||
| if (baselineTopology == null) |
There was a problem hiding this comment.
Why doesn't hasBaseline use here?
EdShangGG
reviewed
Oct 6, 2017
| return false; | ||
| } | ||
|
|
||
| private static boolean isApplicable(ChangeGlobalStateMessage msg, DiscoveryDataClusterState state) { |
EdShangGG
reviewed
Oct 6, 2017
| return !msg.baselineTopology().equals(state.baselineTopology()); | ||
| } | ||
|
|
||
| private static boolean isEquivalent(DiscoveryDataClusterState oldState, DiscoveryDataClusterState newState) { |
EdShangGG
reviewed
Oct 6, 2017
| * @param msg State change message. | ||
| * @return Wrapped state change future. | ||
| */ | ||
| protected IgniteInternalFuture<?> wrapStateChangeFuture(IgniteInternalFuture fut, ChangeGlobalStateMessage msg) { |
There was a problem hiding this comment.
What is the aim of extracting such method?
…ks when BLT is changed.
…ks when BLT is changed.
added 2 commits
October 24, 2017 14:41
# Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/processors/cluster/GridClusterStateProcessor.java # modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsIgniteMock.java
|
The ticket is resolved, closing PR. Feel free to reopen if it is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.