IGNITE-6872 Linear regression should implement Model API #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
November 20, 2017 14:53
- regression examples moved to more appropriate package -- verified with diffs overview, clean build and execution of unit tests
- added missing package-info -- verified with diffs overview
- implementation, tests and examples - accommodated changes done to OLS per IGNITE-5846 - fixed some issues with coding style and javadoc -- verified with diffs overview, clean build, execution of unit tests and examples
- decision trees example moved to more appropriate package -- verified with diffs overview
- corrections per review -- verified with diffs overview
- corrections per review -- verified with diffs overview
- corrections per review -- verified with diffs overview
- corrections per review -- verified with diffs overview
- corrections per review -- verified with diffs overview
- corrections per review -- verified with diffs overview, clean build, execution of unit tests and examples
- OLS regression Trainer wip - preliminary cleanup of QR decomposition -- verified with diffs overview, clean build, execution of unit tests and examples
- OLS regression Trainer wip - adapter from QR decomposition to trainer -- verified with diffs overview, clean build and execution of unit tests
- OLS regression Trainer implemented -- verified with diffs overview, clean build, execution of unit tests and examples
# Conflicts: # modules/ml/src/test/java/org/apache/ignite/ml/LocalModelsTest.java # modules/ml/src/test/java/org/apache/ignite/ml/regressions/DistributedBlockOLSMultipleLinearRegressionTest.java # modules/ml/src/test/java/org/apache/ignite/ml/regressions/DistributedOLSMultipleLinearRegressionTest.java
- merge from master -- verified with diffs overview, clean build and execution of unit tests
- corrections per review -- verified with diffs overview
- corrections per review discussion -- verified with diffs overview
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model and Trainer API implemented for OLS regression