Ignite-6430: CacheGroupsMetricsRebalanceTest.testRebalanceEstimateFinishTime test fails periodically #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SharplEr
changed the title
lvanan
reviewed
Apr 27, 2018
|
|
||
| try { | ||
| while (finishRebalanceLatch.getCount() != 0) { | ||
| while (finishRebalanceLatch.getCount() != 0L) { |
There was a problem hiding this comment.
Let's remove L postfix from this place.
| @@ -223,26 +223,26 @@ public void testRebalanceEstimateFinishTime() throws Exception { | |||
| // Waiting 25% keys will be rebalanced. | |||
| int partKeys = KEYS / 2; | |||
|
|
|||
| final long keysLine = (long)(partKeys - (partKeys * 0.25)); | |||
| final long keysLine = partKeys - partKeys / 4; | |||
There was a problem hiding this comment.
I think, it could be transform to something like partKeys*3/4, due to partKeys is long and partKeys is int and overflow is excluded.
|
|
||
| long timePassed = U.currentTimeMillis() - startTime; | ||
| long timeLeft = finishTime - System.currentTimeMillis(); | ||
| currentTime = System.currentTimeMillis(); |
There was a problem hiding this comment.
May be use U.currentTimeMillis() instead of System.currentTimeMillis()?
| ); | ||
|
|
||
| System.clearProperty(IGNITE_REBALANCE_STATISTICS_TIME_INTERVAL); | ||
|
|
||
| System.out.println("Rebalance time:" + (U.currentTimeMillis() - startTime)); | ||
| currentTime = System.currentTimeMillis(); |
There was a problem hiding this comment.
What about U.currentTimeMillis()?
|
|
||
| assertTrue(finishRebalanceLatch.await(timeLeft + 2_000, TimeUnit.SECONDS)); | ||
| assertTrue("Got timeout while waiting to rebalance. Estimated left time: " + timeLeft + '.', |
There was a problem hiding this comment.
'Got timeout while waiting for rebalance'
| assertTrue((U.currentTimeMillis() - startTime) < 5000); | ||
| assertTrue((U.currentTimeMillis() - startTime) > 0); | ||
| assertTrue("Invalid start time: " + startTime + ", but the current time: " + currentTime + '.', | ||
| startTime > 0L && (currentTime - startTime) >= 0L && (currentTime - startTime) <= 5000L); |
There was a problem hiding this comment.
We should take rebalancing delay into consideration.
There was a problem hiding this comment.
@1vanan There is no delay in CACHE1 config.
|
|
||
| assertTrue("Expected less 5000, Actual:" + diff, Math.abs(diff) < 10_000); | ||
| assertTrue("Expected less than 5000, but actual: " + diff + '.', Math.abs(diff) < 10_000L); |
| @@ -254,32 +254,44 @@ public void testRebalanceEstimateFinishTime() throws Exception { | |||
| } | |||
| }); | |||
|
|
|||
| assertTrue(latch.await(getTestTimeout(), TimeUnit.MILLISECONDS)); | |||
| assertTrue("Got timeout while waiting 25% keys will be rebalanced.", | |||
|
|
||
| CacheMetrics metrics = ig2.cache(CACHE1).localMetrics(); | ||
|
|
||
| long startTime = metrics.getRebalancingStartTime(); | ||
| long currentTime = System.currentTimeMillis(); |
There was a problem hiding this comment.
Change it with U.currentTimeMillis(); pls
SharplEr
force-pushed
the
ignite-6430
branch
3 times, most recently
from
605b070
to
6275b6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For IGNITE-6430
Please see my comments in Ignite Jira if you a bit lost in PR.