IGNITE-7993 Striped pool can't be disabled #4235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhdanov
reviewed
Jul 4, 2018
|
|
||
| assertEquals("Cache should contain saved object", val, cache.get(key)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Need to add balnk line - file should finish with blank one
| @@ -276,11 +277,17 @@ else if (desc.receivedFromStartVersion() != null) | |||
| } | |||
| }; | |||
|
|
|||
| if (stripe >= 0) | |||
| cctx.kernalContext().getStripedExecutorService().execute(stripe, c); | |||
| GridKernalContext kernalContext = cctx.kernalContext(); | |||
There was a problem hiding this comment.
we usually use ctx for kernal context and cctx for cache context. Please rename kernalContext to ctx
| @@ -0,0 +1,113 @@ | |||
| /* | |||
There was a problem hiding this comment.
You need to add more tests including full api and fault-tolerance tests with disabled striped pool.
There was a problem hiding this comment.
Added DisabledStripedExecutorFailoverTest and DisabledStripedExecutorFullApiTest. Please let me know if we need more tests.
|
There is going to be implemented a strict thread per partition in the nearest future which will make disabling of striped pool impossible. I am closing this PR. New one PR will be created to update Javadoc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restored the capability to disable striped pool