IGNITE-8158 Wrap the method afterTestsStopped() call with try/catch b… #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mmuzaf
reviewed
Aug 1, 2018
| if (isLastTest() && isSafeTopology() && stopGridErr) | ||
| throw new RuntimeException("Not all Ignite instances has been stopped. Please, see log for details."); | ||
| if (isLastTest()) { | ||
| if (err != null) |
There was a problem hiding this comment.
You can use RuntimeException(String message, Throwable cause) constructor to reduce this if-else statement. As I can see, cause can be nullable.
Mmuzaf
reviewed
Aug 1, 2018
| try { | ||
| afterTestsStopped(); | ||
| } | ||
| catch (Exception e){ |
There was a problem hiding this comment.
Suppose, we've missed space here?
zzzadruga
force-pushed
the
IGNITE-8158
branch
2 times, most recently
from
0aeacab
to
72fb701
Compare
zzzadruga
force-pushed
the
IGNITE-8158
branch
2 times, most recently
from
3ac453c
to
93b2a66
Compare
SGrimstad
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Sep 11, 2018
Fixes apache#4464. Signed-off-by: Nikolay Izhikov <nizhikov@apache.org>
akalash
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Nov 19, 2018
Fixes apache#4464. Signed-off-by: Nikolay Izhikov <nizhikov@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lock