IGNITE-9433 Extracted zip suffix constant #4652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EdShangGG could you please review |
akalash
reviewed
Aug 31, 2018
| @@ -77,6 +77,8 @@ | |||
| /** File suffix. */ | |||
| public static final String FILE_SUFFIX = ".bin"; | |||
|
|
|||
| public static final String ZIP_SUFFIX = ".zip"; | |||
There was a problem hiding this comment.
Can you add javadoc to variable.
akalash
reviewed
Aug 31, 2018
| @@ -121,7 +122,7 @@ public String getAbsolutePath() { | |||
|
|
|||
| /** {@inheritDoc} */ | |||
| @Override public boolean isCompressed() { | |||
| return file.getName().endsWith(".zip"); | |||
| return file.getName().endsWith(FilePageStoreManager.ZIP_SUFFIX); | |||
There was a problem hiding this comment.
Maybe better use static import?
There was a problem hiding this comment.
whyfor? i don't think this is readable, except for tests
akalash
reviewed
Aug 31, 2018
| @@ -2104,9 +2105,9 @@ private void deleteObsoleteRawSegments() { | |||
| if (currReservedSegment == -1) | |||
| continue; | |||
|
|
|||
| File tmpZip = new File(walArchiveDir, FileDescriptor.fileName(currReservedSegment) + ".zip" + ".tmp"); | |||
| File tmpZip = new File(walArchiveDir, FileDescriptor.fileName(currReservedSegment) + FilePageStoreManager.ZIP_SUFFIX + ".tmp"); | |||
There was a problem hiding this comment.
Can you extract ".tmp" too
SGrimstad
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Sep 11, 2018
…he#4652. Signed-off-by: Dmitriy Govorukhin <dmitriy.govorukhin@gmail.com>
voropava
added a commit
to gridgain/apache-ignite
that referenced
this pull request
Sep 14, 2018
voropava
added a commit
to gridgain/apache-ignite
that referenced
this pull request
Sep 17, 2018
akalash
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Nov 19, 2018
…he#4652. Signed-off-by: Dmitriy Govorukhin <dmitriy.govorukhin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ci.ignite.apache.org/viewLog.html?buildId=1760367&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_RunAll