Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-4111 #4685

Closed
wants to merge 56 commits into from
Closed

IGNITE-4111 #4685

wants to merge 56 commits into from

Conversation

NSAmelchev
Copy link
Contributor

@NSAmelchev NSAmelchev commented Sep 5, 2018

Fix for IGNITE-4111 Communication fails to send message if target node did not finish join process

I partially fixed PR provided by @akuramshingg:

  1. Fix for SSL. (It was also incorrect behavior)
  2. Moved out message class to others messages.
  3. Used internal utilities.
  4. I have rewritten test. The provided test doesn't reproduce a problem correctly. Also, I have added the test for the case when SSL enabled.
  5. Fixed code style problems.

akuramshingg and others added 30 commits November 18, 2016 23:12
fix message codes comment
# Conflicts:
#	modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
…into ignite-4111

# Conflicts:
#	modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
#	modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java
# Conflicts:
#	modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
# Conflicts:
#	modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
@asfgit asfgit closed this in a4a66d6 Dec 10, 2018
voropava pushed a commit to gridgain/apache-ignite that referenced this pull request Jan 22, 2019
…a message to a not yet joined node - Fixes apache#4685.

Signed-off-by: Alexey Goncharuk <alexey.goncharuk@gmail.com>

(cherry picked from commit a4a66d6)
voropava pushed a commit to gridgain/apache-ignite that referenced this pull request Jan 22, 2019
…a message to a not yet joined node - Fixes apache#4685.

Signed-off-by: Alexey Goncharuk <alexey.goncharuk@gmail.com>

(cherry picked from commit a4a66d6)
macrergate pushed a commit to gridgain/apache-ignite that referenced this pull request Jan 22, 2019
…a message to a not yet joined node - Fixes apache#4685.

Signed-off-by: Alexey Goncharuk <alexey.goncharuk@gmail.com>
(cherry picked from commit a4a66d6)
macrergate pushed a commit to gridgain/apache-ignite that referenced this pull request Jan 22, 2019
…a message to a not yet joined node - Fixes apache#4685.

Signed-off-by: Alexey Goncharuk <alexey.goncharuk@gmail.com>
(cherry picked from commit a4a66d6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants