IGNITE-9606: JDBC getPrimaryKeys() returns wrong value for COLUMN_NAME #4906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier, if key was of SQL type (so not wrapped), corresponding property thought that it is not a key. This behaviour affected what COLUMN_NAME JDBC metadata would contain.
pavel-kuznetsov
commented
Oct 3, 2018
| isKeyField = false; | ||
| if (isKeyClsSqlType) | ||
| // In case of field is neither composite nor wrapped, it is a key, if it equal to keyFieldName. | ||
| isKeyField = entry.getKey().equals(qryEntity.getKeyFieldName()); | ||
| else | ||
| isKeyField = (hasKeyFields ? keyFields.contains(entry.getKey()) : null); |
There was a problem hiding this comment.
Could someone explain, when we need to set isKeyField to null?
| isKeyField = false; | ||
| if (isKeyClsSqlType) | ||
| // In case of field is neither composite nor wrapped, it is a key, if it equal to keyFieldName. | ||
| isKeyField = entry.getKey().equals(qryEntity.getKeyFieldName()); |
There was a problem hiding this comment.
is it correct that you check it case sensitive?
prop.name() used to return UPPERCASED name of the field. So comparison with keyFieldName/valueFieldName (which are not uppercased) was incorrect. Probably, this validation logic should be revisited.
Used aliases map instead of normalizing keyFieldName all the time.
|
Afrer review, decieded to fix problem in another way |
devozerov
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Oct 12, 2018
…ta. This closes apache#4906. This closes apache#4948.
akalash
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Nov 19, 2018
…ta. This closes apache#4906. This closes apache#4948.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.