IGNITE-10776 Migrate from JUnit 3 to 4 config variations test suites #5781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
January 7, 2019 01:32
- initial draft -- verified with diffs overview, rebuild and execution of reworked self-test
- fixes for IDEA warnings -- verified with diffs overview, rebuild and execution of reworked self-test
- draft fully tested, ready for use -- verified with diffs overview, rebuild and execution of reworked self-test
- test improved -- verified with diffs overview, rebuild and execution of reworked self-test
- minor cleanup -- verified with diffs overview
- wip -- verified with diffs overview, rebuild and execution of reworked self-test
- wip -- verified with diffs overview, rebuild and execution of reworked self-test
- final cleanup -- verified with diffs overview, rebuild and execution of reworked self-test
- code cleanup per self-review -- verified with diffs overview and rebuild
# Conflicts: # modules/core/src/test/java/org/apache/ignite/testframework/configvariations/ConfigVariationsTestSuiteBuilder.java
- manual merge correction -- verified with diffs overview and rebuild
- reworked per review comments (javaassist) -- verified with diffs overview, rebuild and execution of unit tests
- fix for errors discovered by TC bot -- verified with diffs overview, rebuild and execution of unit tests
- unit test for errors discovered by TC bot -- verified with diffs overview, rebuild and execution of unit tests
- fix for errors discovered by TC bot -- verified with diffs overview, rebuild and execution of unit tests
- unit test for errors discovered by TC bot -- verified with diffs overview, rebuild and execution of unit tests
- fix for errors discovered by TC bot -- verified with diffs overview, rebuild and execution of unit tests
| */ | ||
| @RunWith(AllTests.class) | ||
| /** */ | ||
| @RunWith(IgniteCacheReadThroughEvictionsVariationsSuite.DynamicSuite.class) | ||
| public class IgniteCacheReadThroughEvictionsVariationsSuite { |
There was a problem hiding this comment.
It seems logical to move this test to the testsuites package where other suite classes reside.
…uite runner into all suite classes
- reworked per review comments (DynamicSuite) -- verified with diffs overview, rebuild and execution of unit tests
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.