IGNITE-10834: Add NamedVector into ML module. #5881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avplatonov
reviewed
Jan 23, 2019
| */ | ||
| public static NamedVector of(Map<String, Double> values) { | ||
| SparseVector vector = new SparseVector(values.size(), StorageConstants.RANDOM_ACCESS_MODE); | ||
| for (int i = 0; i < values.size(); i++) |
There was a problem hiding this comment.
What's the reason for Double.NaN setting? You don't use these values below.
| * Delegating named vector that delegates all operations to underlying vector and adds implementation of | ||
| * {@link NamedValue} functionality using embedded map that maps string index on real integer index. | ||
| */ | ||
| public class DelegatingNamedVector extends DelegatingVector implements NamedVector { |
There was a problem hiding this comment.
I don't like that vector operations hide real type of result - sum of NamedVectors will be Vector. Moreover, there is no checks of keys equality for different NamedVectors. Maybe we need generics?))
There was a problem hiding this comment.
Yes, it makes sense. I've slightly changed approach and made SimpleNamedVector that implements AbstractVector, at the same time AbstractVector is more generic. Please, have a look.
artemmalykh
approved these changes
Jan 23, 2019
avplatonov
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.