IGNITE-6957 Boxing / Unboxing optimization - added IntSet. #6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibessonov
reviewed
Jun 21, 2019
...e/src/main/java/org/apache/ignite/internal/processors/affinity/GridAffinityAssignmentV2.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/ignite/internal/processors/affinity/GridAffinityAssignmentV2.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/util/collection/BitSetIntSet.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/util/collection/BitSetIntSet.java
Show resolved
Hide resolved
| } | ||
| else | ||
| return false; | ||
| return bitSet.nextSetBit(idx + 1) != -1; |
There was a problem hiding this comment.
I suggest the optimization: store nextIdx in field after calculation. We can easily support following invariant:
- idx == nextIdx - "hasNext" hasn't been invoked or set is empty.
- idx != nextIdx - "hasNext" has been invoked and set is not empty, "next" has not been invoked (each "next" invocation will execute "nextIdx = idx = nextIdx").
What do you think? It'll reduce number of array scans to 1 instead of 2.
modules/core/src/main/java/org/apache/ignite/internal/util/collection/IntHashMap.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/util/collection/IntHashMap.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/util/collection/IntHashMap.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/util/collection/IntHashMap.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/util/collection/IntHashMap.java
Outdated
Show resolved
Hide resolved
ibessonov
reviewed
Jun 28, 2019
| * @param key Targert key. | ||
| */ | ||
| protected int index(int key) { | ||
| return (entries.length - 1) & (key ^ (key >>> 16)); |
There was a problem hiding this comment.
We can use better hash function here and cache this value in methods whenever it's possible.
| protected int distance(int curIdx, int key) { | ||
| int keyIdx = index(key); | ||
|
|
||
| return curIdx >= keyIdx ? curIdx - keyIdx : entries.length - keyIdx + curIdx; |
There was a problem hiding this comment.
"curIdx >= keyIdx" uses subtraction implicitly, so you make it twice.
"curIdx - keyIdx" can be calculated a line before, comparing it to zero will be "much faster".
modules/core/src/main/java/org/apache/ignite/internal/util/collection/IntHashMap.java
Outdated
Show resolved
Hide resolved
...es/core/src/test/java/org/apache/ignite/internal/util/collection/AbstractBaseIntMapTest.java
Show resolved
Hide resolved
modules/core/src/test/java/org/apache/ignite/internal/util/collection/IntHashMapTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheMetricsImpl.java # modules/core/src/test/java/org/apache/ignite/internal/util/collection/BitSetIntSetTest.java
glukos
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Aug 12, 2019
…accessing cache by ID - Fixes apache#6536.
glukos
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Aug 12, 2019
…accessing cache by ID - Fixes apache#6536.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.