FOR TEST POC evict index partitions #6941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nizhikov
reviewed
Oct 15, 2019
| @@ -164,6 +164,9 @@ | |||
| * reservation is released. */ | |||
| private volatile boolean delayedRenting; | |||
|
|
|||
| /** Set if partition is requested for exclusive evict. */ | |||
| private volatile boolean exclClear; | |||
There was a problem hiding this comment.
Let's rename it to the exclPurge.
nizhikov
reviewed
Oct 15, 2019
| * @param fut Future to listen for completion of a larger clear procedure. | ||
| * @return {@code true} if successfully initialized, otherwise a retry is required. | ||
| */ | ||
| public boolean exclusiveClearAsync(IgniteInternalFuture<Void> fut) { |
There was a problem hiding this comment.
Who protect this method in case of concurrent invocation?
|
We have Seems, we should encapsulate |
|
We have to ensure consistent naming in PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.