IGNITE-12302 Test ZookeeperDiscoveryTopologyChangeAndReconnectTest.testDuplicatedNodeId is broken. #6986
Conversation
| @@ -562,32 +564,23 @@ public void testForcibleClientFail() throws Exception { | |||
| * @throws Exception If failed. | |||
| */ | |||
| @Test | |||
| @WithSystemProperty(key = IGNITE_SQL_DISABLE_SYSTEM_VIEWS, value = "true") | |||
There was a problem hiding this comment.
IgniteH2Indexing connects to H2 instance by URL based on nodeId, so there can be more errors in indexing here in the future even if system views are disabled.
Perhaps it's better to disable indexing at all for this test (something like GridQueryProcessor.idxCls = DummyQueryIndexing.class; before each grid start).
There was a problem hiding this comment.
@alex-plekhanov, thanks for the suggestion. I have fixed the test. Could you take a look? TC test suite looks fine.
| @Override protected void afterTest() throws Exception { | ||
| super.afterTest(); | ||
|
|
||
| indexingDisabled = false; |
There was a problem hiding this comment.
You should also return the value of GridQueryProcessor.idxCls to null (in case startGrid fails)
| if (indexingDisabled) { | ||
| GridQueryProcessor.idxCls = DummyQueryIndexing.class; | ||
|
|
||
| cfg.setSystemViewExporterSpi(new JmxSystemViewExporterSpi() { |
There was a problem hiding this comment.
Let's fix SqlViewExporterSpi instead of excluding it (looks like a bug in its implementation)
There was a problem hiding this comment.
@alex-plekhanov, I have fixed it. Take a look, please. Tests OK.
…AndReconnectTest.testDuplicatedNodeId - Fixes apache#6986. Signed-off-by: Aleksey Plekhanov <plehanov.alex@gmail.com>
Fixed test by disabling registering system views.
Optimized test speed by decreasing server join tries counts.
Added correct SPI exception check.