IGNITE-10760 Fix confusing message about system worker blocking #7047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agura
suggested changes
Nov 13, 2019
| "This can lead to cluster-wide undefined behaviour " + | ||
| "[threadName=" + worker.name() + ", blockedFor=" + heartbeatDelay / 1000 + "s]"); | ||
| "This can lead to cluster-wide undefined behaviour " + | ||
| "[workerName=" + worker.name() + ", threadName=" + worker.runner().getName() + |
There was a problem hiding this comment.
worker.runner() can return null in some cases, so it makes sense to add additional null checking.
There was a problem hiding this comment.
As far as I can see from the code, the check has already been done at
So it seems to me that we don't need to do additional check.
I can change worker.runner() to runner to make code cleaner, if it needed.
There was a problem hiding this comment.
It's classic check-then-act error. In your case NullPointerException is still possible. But using runner instead of worker.runner() solves the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.