IGNITE-12505 Improve logging of data regions on startup. #7209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlukhin
reviewed
Jan 9, 2020
| @@ -18,11 +18,15 @@ | |||
| package org.apache.ignite.internal.processors.cache.persistence; | |||
|
|
|||
| import java.io.File; | |||
| import java.text.DecimalFormat; | |||
There was a problem hiding this comment.
Do we really need visual representation stuff in IgniteCacheDatabaseSharedManager? Can we extract it somewhere?
| @@ -99,6 +106,9 @@ | |||
| /** DataRegionConfiguration name reserved for internal caches. */ | |||
| public static final String SYSTEM_DATA_REGION_NAME = "sysMemPlc"; | |||
|
|
|||
| public static Set<String> INTERNAL_DATA_REGION_NAMES = Collections.unmodifiableSet( | |||
| U.quiet(false, "Data Regions Started: " + dataRegionMap.size()); | ||
|
|
||
| U.quietMultipleLines(false, IgniteKernal.dataStorageReport(this, dblFmt, false)); | ||
| } else if (log.isInfoEnabled()) { |
There was a problem hiding this comment.
According to code style else if should come from a new line.
| assertTrue(msg, fullLog.matches("(?s).*Outbound messages queue \\[size=.*].*")); | ||
| assertTrue(msg, fullLog.matches("(?s).*Public thread pool \\[active=.*, idle=.*, qSize=.*].*")); | ||
| assertTrue(msg, fullLog.matches("(?s).*System thread pool \\[active=.*, idle=.*, qSize=.*].*")); | ||
| assertTrue(msg, fullLog.matches("(?s).*" + CUSTOM_EXECUTOR_0 + " \\[active=.*, idle=.*, qSize=.*].*")); | ||
| assertTrue(msg, fullLog.matches("(?s).*" + CUSTOM_EXECUTOR_1 + " \\[active=.*, idle=.*, qSize=.*].*")); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Extra empty line (according to code style).
| double freeOffHeapPct = offHeapMaxSummary > 0 ? | ||
| ((double)((offHeapMaxSummary - offHeapUsedSummary) * 100)) / offHeapMaxSummary : -1; | ||
|
|
||
| return (includeMemoryStatistics ? |
There was a problem hiding this comment.
It is hard for me to read ternary operator for this statement. I suggest to extract methods assembling message pieces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.