IGNITE-12779 : Split implementations of Ignite and IgniteMXBean, make behavior of their active(boolean) different #7531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vladsz83
changed the title
Vladsz83
changed the title
NSAmelchev
reviewed
Mar 17, 2020
modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java
Outdated
Show resolved
Hide resolved
| LOAD_BALANCING_SPI_FORMATTED_DESC); | ||
| } | ||
|
|
||
| /** | ||
| * @return String representation of version of current Ignite instance. |
| @@ -131,7 +132,7 @@ public void registerAllMBeans( | |||
| return; | |||
|
|
|||
| // Kernal | |||
| registerMBean("Kernal", IgniteKernal.class.getSimpleName(), kernal, IgniteMXBean.class); | |||
| registerMBean("Kernal", IgniteKernal.class.getSimpleName(), new IgniteMXBeanImpl(kernal), IgniteMXBean.class); | |||
There was a problem hiding this comment.
Create mbean var, please
NSAmelchev
reviewed
Mar 17, 2020
| @@ -455,9 +455,6 @@ | |||
|
|
|||
| /** | |||
| * Changes Ignite grid state to active or inactive. | |||
| * <p> | |||
NSAmelchev
reviewed
Mar 17, 2020
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public void printLastErrors() { | ||
| kernal.context().exceptionRegistry().printErrors(log); |
There was a problem hiding this comment.
Lets create printLastErrors in the kerrnal like osUser methods. Log will not be needed.
NSAmelchev
reviewed
Mar 17, 2020
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public boolean isRebalanceEnabled() { | ||
| return kernal.context().cache().context().isRebalanceEnabled(); |
There was a problem hiding this comment.
Lets use isRebalanceEnabled from kernal
NSAmelchev
reviewed
Mar 17, 2020
| kernal.context().gateway().readLock(); | ||
|
|
||
| try { | ||
| return kernal.context().state().publicApiActiveState(true); |
There was a problem hiding this comment.
Lets use kernal.active()
NSAmelchev
reviewed
Mar 17, 2020
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public void rebalanceEnabled(boolean rebalanceEnabled) { | ||
| kernal.context().cache().context().rebalanceEnabled(rebalanceEnabled); |
There was a problem hiding this comment.
Lets use kernal.rebalanceEnabled(rebalanceEnabled);
NSAmelchev
approved these changes
Mar 18, 2020
# Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/managers/IgniteMBeansManager.java # modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteClusterActivateDeactivateTest.java # modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/HadoopJobTrackerSelfTest.java
NSAmelchev
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior changes:
IgniteMXBean.active(false) and IgniteMXBean.state("inactive") now throw an exception if deactivation would clear in-memory data.
Major code changes:
Additionally, as discussed, improved comments
/** If {@code true}, cluster deactivation will be forced. */
to more complete descriptions.