IGNITE-13218 fixed. importComparator added to TreeSet to provide core… #8187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anton-vinogradov , @agoncharuk for some reasons I can't add reviewers to this PR |
NSAmelchev
reviewed
Aug 26, 2020
| @@ -148,7 +148,8 @@ public static void main(String[] args) throws Exception { | |||
| */ | |||
| private <T> Collection<String> generate(Class<T> clazz) { | |||
| final List<String> code = new ArrayList<>(); | |||
| final Set<String> imports = new TreeSet<>(); | |||
| Comparator<String> importComparatror = (s1, s2) -> s1.replace(";","").compareTo(s2.replace(";","")); | |||
There was a problem hiding this comment.
@aleksey-kurinov There is typo in the var name. There is no white space between parameters. (See CodingGuidelines)
I suggest to pass comparator to the constructor parameter:
new TreeSet<>(Comparator.comparing(s -> s.replace(";", "")))
NSAmelchev
approved these changes
Aug 27, 2020
alex-plekhanov
approved these changes
Aug 27, 2020
kartiksomani
pushed a commit
to kartiksomani/ignite
that referenced
this pull request
Sep 15, 2020
ymolochkov
pushed a commit
to ymolochkov/ignite
that referenced
this pull request
Nov 19, 2020
apache#8187) (cherry picked from commit 81dd397)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imports order was incorrect because if default lexicographical comparator
"import org.apache.ignite.spi.systemview.view.ComputeJobView.ComputeJobState;" is less "import org.apache.ignite.spi.systemview.view.ComputeJobView;"
however if we remove semicolom uring comparing the problem is fixed
so to fix the problem I've added custom comparator to "imports" TreeSet