IGNITE-13028 Spring Data integration introspects the fields of the key object #8328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamar
suggested changes
Oct 13, 2020
alamar
reviewed
Oct 15, 2020
There was a problem hiding this comment.
The change looks good, but there are some formatting issues.
Please fix them to learn how we structure code newline-wise.
Please consult https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-Whitespacesandemptylines
| @@ -39,7 +41,13 @@ private IgniteQueryGenerator() { | |||
| * @return Generated ignite query. | |||
| */ | |||
| public static IgniteQuery generateSql(Method mtd, RepositoryMetadata metadata) { | |||
| PartTree parts = new PartTree(mtd.getName(), metadata.getDomainType()); | |||
| PartTree parts; | |||
| try { | |||
There was a problem hiding this comment.
blank line is probably needed above
| */ | ||
| private static String getColumnName(Part part, Class<?> domainType) { | ||
| PropertyPath prperty = part.getProperty(); | ||
| if (prperty.getType() != domainType) |
| * */ | ||
| public class IgniteSpringDataCompoundKeyTest extends GridCommonAbstractTest { | ||
|
|
||
| /** Application context */ |
There was a problem hiding this comment.
blank line NOT needed at the start of class
| */ | ||
| @Override protected void beforeTestsStarted() throws Exception { | ||
| super.beforeTestsStarted(); | ||
| ctx = new AnnotationConfigApplicationContext(); |
| ctx = new AnnotationConfigApplicationContext(); | ||
| ctx.register(CompoundKeyApplicationConfiguration.class); | ||
| ctx.refresh(); | ||
| repo = ctx.getBean(CityRepository.class); |
| * */ | ||
| @Override protected void beforeTest() throws Exception { | ||
| super.beforeTest(); | ||
| loadData(); |
| /** load data*/ | ||
| public void loadData() throws Exception { | ||
| Ignite ignite = ctx.getBean(Ignite.class); | ||
| if (ignite.cacheNames().contains(CACHE_NAME)) |
|
|
||
| try (Connection conn = DriverManager.getConnection("jdbc:ignite:thin://127.0.0.1/")) { | ||
| Statement st = conn.createStatement(); | ||
| st.execute("DROP TABLE IF EXISTS City"); |
| * Value-class | ||
| * */ | ||
| public class City { | ||
|
|
|
|
||
| /** Compound key for city class */ | ||
| public class CityKey implements Serializable { | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IgniteQueryGenerator added searching key fields among field of key-class.