IGNITE-13489 Clients log in and out of the topology #8362

SwirMix · 2020-10-14T20:46:19Z

client start and stop in loop

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

There is a single JIRA ticket related to the pull request.
The web-link to the pull request is attached to the JIRA ticket.
The JIRA ticket has the Patch Available state.
The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

client start and stop in loop

modules/ducktests/tests/ignitetest/services/ignite_app.py

timoninmaxim · 2020-10-16T09:48:06Z

modules/ducktests/tests/ignitetest/services/ignite_app.py


        self.__check_status("IGNITE_APPLICATION_FINISHED", timeout=timeout_sec)

-    # pylint: disable=W0221
-    def stop_node(self, node, clean_shutdown=True, timeout_sec=10):


As I see you just move this method higher. Let's revert it.
Why do you change timeout_sec?

revert changes

timoninmaxim · 2020-10-16T09:58:53Z

modules/ducktests/tests/ignitetest/services/ignite_app.py

+            output = node.account.ssh_capture(
+                "grep '%s' %s" % (name + "->", self.STDOUT_STDERR_CAPTURE), allow_fail=False)
+            for line in output:
+                res.append(re.search("%s(.*)%s" % (name + "->", "<-"), line).group(1))


Imagine you have multiple application nodes, all of them are failed. res than contains multiple lines. In method above extract_result it checks size of the error and raises exception.

Yes, I see. Then it is better to build a check based on a dynamic parameter. I mean, instead of the expected 1 line, expect len(self.nodes). Am I getting this right?

timoninmaxim · 2020-10-16T09:59:39Z

.../src/main/java/org/apache/ignite/internal/ducktest/tests/start_stop_client/SimpleClient.java

+/**
+ * Java client. Tx put operation
+ */
+public class SimpleClient extends IgniteAwareApplication {


Let's rename simple client to smth more meaningful.

OK, what about IgniteCachePutClient?

timoninmaxim · 2020-10-16T10:07:59Z

modules/ducktests/tests/ignitetest/tests/client_in_out_test.py

+    """
+
+    CACHE_NAME = "simple-tx-cache"
+    PACING = 10


Pacing is an internal delay, the interval between discrete operations. This is a customized parameter, 10 ms is selected so that we know for sure that the average number of operations generated by the client does not exceed 100 operations per second

timoninmaxim · 2020-10-16T10:08:06Z

modules/ducktests/tests/ignitetest/tests/client_in_out_test.py

+    PACING = 10
+    JAVA_CLIENT_CLASS_NAME = "org.apache.ignite.internal.ducktest.tests.start_stop_client.SimpleClient"
+
+    CLIENTS_WORK_TIME_S = 30


CLIENTS_WORK_TIME_S - the working time of the client group. It is selected in such a way as to allow time for the load level to stabilize. A certain number of clients are included in the topology and work in this number of CLIENTS_WORK_TIME_S of time. From my point of view, this operating time is not too high, but it is sufficient for the load level on the cluster to settle after new fat clients enter the cluster. But I admit that I'm wrong.

timoninmaxim · 2020-10-16T10:08:27Z

modules/ducktests/tests/ignitetest/tests/client_in_out_test.py

+        for i in range(self.ITERATION_COUNT):
+            self.logger.debug(f'Starting iteration: {i}.')
+
+            time.sleep(self.CLIENTS_WORK_TIME_S)


Why do you sleep on first iteration?

We give the STATIC_CLIENTS_NUM client group time to WORK during the CLIENTS_WORK_TIME_S time for each iteration of the TEMP_CLIENTS_NUM client group entry and exit. This is done in order to get a stable state of the cluster under a stable load after each client login and exit procedure

timoninmaxim · 2020-10-21T08:56:32Z

modules/ducktests/tests/ignitetest/tests/client_in_out_test.py

+        for node in service.nodes:
+            service.stop_node(node=node, clean_shutdown=False)
+    else:
+        service.stop(clean_shutdown=True)


Why do not replace this if-else block with service.stop(clean_shutdown=kill_nodes)?

the base timeout of 10 seconds was not enough to register completion in the base method. However, when they are completed sequentially, I fit into the timeout

It's because service.stop waits for completion message "IGNITE_APPLICATION_FINISHED" in any case. So if clean_shutdown is False there is no reason to wait the message. So. It's a bug of stop method. Let's fix it instead

I guessed, but I was even more afraid to rule. Okay, I'll fix it.

timoninmaxim · 2020-10-21T09:28:45Z

modules/ducktests/tests/ignitetest/services/ignite_app.py

@@ -110,7 +121,8 @@ def extract_result(self, name):
        """
        results = self.extract_results(name)

-        assert len(results) <= 1, f"Expected exactly one result occurence, {len(results)} found."
+        assert len(results) <= len(self.nodes), f"Expected exactly {len(self.nodes)} occurence," \


let's replace <= with !=.

only here it is necessary ==

timoninmaxim · 2020-10-21T09:40:33Z

modules/ducktests/tests/ignitetest/tests/client_in_out_test.py

+                 iteration_count=3,
+                 client_work_time=30)
+    # pylint: disable=R0913
+    def test_ignite_start_stop_nodes(self, ignite_version,


To enable run the test in parallel with others please use @cluster decorator. If user wants to run experiments with different number of nodes, the one must comment the decorator in feature branch.

Actually we need a flag for ducktape to ignore this decorator if needed. I will make a ticket for that.

ok. I found your ticket thank you!

fix await finish event for clear_shutdown=False

timoninmaxim · 2020-10-23T07:08:10Z

LGTM

SwirMix added 7 commits October 14, 2020 23:31

simple test

b60085d

client start and stop in loop

fix assert

bc5a753

fix ignite_app.py

c29e52c

fix unused varilable

9eb6ff7

add test in fast suit

5985a1c

fix abstract method

c11da91

fix abstract method

4a7580b

timoninmaxim requested changes Oct 16, 2020

View reviewed changes

SwirMix added 6 commits October 16, 2020 14:53

change classname

b89c98f

check result assert

1831fd5

add kill node test

f81b0ba

fix

bffa05f

rm Project_Default.xml

333fa82

iteration count

12b3a21

timoninmaxim reviewed Oct 21, 2020

View reviewed changes

SwirMix added 7 commits October 21, 2020 15:17

fix check result,

8c2d350

fix await finish event for clear_shutdown=False

fix check result

d612037

revert Project_Default.xml

2fa9999

revert Project_Default.xml from ignite-ducktape branch

8528c0b

flip flags

fc9509a

rename flag kill_temp_nodes

71fd004

fix await event in test

777bf5e

timoninmaxim approved these changes Oct 23, 2020

View reviewed changes

SwirMix changed the title ~~Ignite 13489 client in out test~~ IGNITE-13489. Clients log in and out of the topology. To validate the topology. Oct 23, 2020

nizhikov changed the title ~~IGNITE-13489. Clients log in and out of the topology. To validate the topology.~~ IGNITE-13489 Clients log in and out of the topology. To validate the topology. Oct 23, 2020

nizhikov changed the title ~~IGNITE-13489 Clients log in and out of the topology. To validate the topology.~~ IGNITE-13489 Clients log in and out of the topology Oct 23, 2020

nizhikov merged commit bd26242 into apache:ignite-ducktape Oct 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IGNITE-13489 Clients log in and out of the topology #8362

IGNITE-13489 Clients log in and out of the topology #8362

SwirMix commented Oct 14, 2020

timoninmaxim Oct 16, 2020

SwirMix Oct 16, 2020

timoninmaxim Oct 16, 2020

SwirMix Oct 16, 2020

timoninmaxim Oct 16, 2020

SwirMix Oct 16, 2020

timoninmaxim Oct 16, 2020

SwirMix Oct 16, 2020

timoninmaxim Oct 16, 2020

SwirMix Oct 16, 2020

timoninmaxim Oct 16, 2020

SwirMix Oct 16, 2020

timoninmaxim Oct 21, 2020

SwirMix Oct 21, 2020

timoninmaxim Oct 21, 2020

SwirMix Oct 21, 2020

timoninmaxim Oct 21, 2020

SwirMix Oct 21, 2020

SwirMix Oct 21, 2020

timoninmaxim Oct 21, 2020

SwirMix Oct 21, 2020

timoninmaxim commented Oct 23, 2020

IGNITE-13489 Clients log in and out of the topology #8362

IGNITE-13489 Clients log in and out of the topology #8362

Conversation

SwirMix commented Oct 14, 2020

The Contribution Checklist

Notes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timoninmaxim commented Oct 23, 2020