New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-9109: Implement SQL API for CPP Thin #8628
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptupitsyn
requested changes
Dec 30, 2020
modules/platforms/cpp/thin-client/include/ignite/thin/cache/query/query_fields_cursor.h
Outdated
Show resolved
Hide resolved
modules/platforms/cpp/thin-client/include/ignite/thin/cache/query/query_fields_row.h
Outdated
Show resolved
Hide resolved
modules/platforms/cpp/thin-client/include/ignite/thin/cache/query/query_fields_row.h
Outdated
Show resolved
Hide resolved
modules/platforms/cpp/thin-client/include/ignite/thin/cache/query/query_fields_row.h
Outdated
Show resolved
Hide resolved
modules/platforms/cpp/thin-client/include/ignite/thin/cache/query/query_fields_row.h
Outdated
Show resolved
Hide resolved
modules/platforms/cpp/thin-client/src/impl/cache/query/query_fields_cursor_impl.h
Outdated
Show resolved
Hide resolved
isapego
commented
Dec 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Please, take another look
modules/platforms/cpp/thin-client/include/ignite/thin/cache/query/query_fields_cursor.h
Outdated
Show resolved
Hide resolved
modules/platforms/cpp/thin-client/include/ignite/thin/cache/query/query_fields_row.h
Outdated
Show resolved
Hide resolved
modules/platforms/cpp/thin-client/include/ignite/thin/cache/query/query_fields_row.h
Outdated
Show resolved
Hide resolved
modules/platforms/cpp/thin-client/include/ignite/thin/cache/query/query_fields_row.h
Outdated
Show resolved
Hide resolved
modules/platforms/cpp/thin-client/src/impl/cache/query/query_fields_cursor_impl.h
Outdated
Show resolved
Hide resolved
modules/platforms/cpp/thin-client/include/ignite/thin/cache/query/query_fields_row.h
Outdated
Show resolved
Hide resolved
ptupitsyn
approved these changes
Dec 30, 2020
shishkovilja
pushed a commit
to shishkovilja/ignite
that referenced
this pull request
Apr 21, 2021
This closes apache#8628
xintrian
pushed a commit
to xintrian/ignite
that referenced
this pull request
May 27, 2022
This closes apache#8628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented SqlFieldsQuery for thin C++ clients and added tests.
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summary
whereXXXX
- number of JIRA issue.(see the Maintainers list)
the
green visa
attached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.