Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-12724 avoid skips in tests #8700

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

masterj63
Copy link

@masterj63 masterj63 commented Jan 25, 2021

Previously we skipped commands that required subcommands in
CommandHandlerParsingTest. This commit appends hard coded valid
arguments to such commands before calling
CommonArgParser.parseAndValidate() to have all CommandList commands
used in tests to increase test coverage.

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

Previously we skipped commands that required subcommands in
CommandHandlerParsingTest. This commit appends hard coded valid
arguments to such commands before calling
CommonArgParser.parseAndValidate() to have all CommandList commands
used in tests to increase test coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant