Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-13588 .NET: Fix SQL type name for generic query types #8708

Merged
merged 19 commits into from Jan 27, 2021

Conversation

ptupitsyn
Copy link
Contributor

@ptupitsyn ptupitsyn commented Jan 26, 2021

BinaryUtils.GetSqlTypeName used to return Type.FullName, which includes assembly-qualified type names for all generic type arguments, which causes the following problems:

  • SQL type name includes assembly versions, so queries stop working if there is a version change
  • Incorrect binary type id is registered through the {{UnmanagedCallbacks.BinaryTypeGet}}

Remove assembly part from the SQL type name to tolerate version changes in the same way as we do for regular binary types.

@ptupitsyn ptupitsyn self-assigned this Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants