IGNITE-14383 No need to update metastorage if cache statistics disabled #8924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nizhikov
reviewed
Mar 26, 2021
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheProcessor.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Mar 26, 2021
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheProcessor.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Mar 26, 2021
| for (IgniteBiTuple<CacheGroupContext, Boolean> grp : grpsToStop) | ||
| stopCacheGroup(grp.get1().groupId(), grp.get2()); | ||
| for (IgniteBiTuple<CacheGroupContext, Boolean> grp : grpsToStop) { | ||
| Boolean stat = grpMetricsToStop.get(grp.get1().groupId()); |
There was a problem hiding this comment.
Are we really need intermediate grpMetricsToStop map?
Let's just calculate statisticsEnabled flag right in place.
There was a problem hiding this comment.
yep ... cause upper we removes it context : prepareCacheStop -> sharedCtx.removeCacheContext(ctx);
nizhikov
reviewed
Mar 26, 2021
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheProcessor.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Mar 26, 2021
| @@ -3262,6 +3281,8 @@ public void processStatisticsModeChange(CacheStatisticsModeChangeMessage msg) { | |||
| private void stopCachesOnClientReconnect(Collection<GridCacheAdapter> stoppedCaches) { | |||
| assert ctx.discovery().localNode().isClient(); | |||
|
|
|||
| boolean stat = stoppedCaches.stream().anyMatch(c -> c.context().statisticsEnabled()); | |||
nizhikov
reviewed
Mar 26, 2021
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheProcessor.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Mar 26, 2021
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheProcessor.java
Outdated
Show resolved
Hide resolved
|
@zstan What if
It seems this scenario will lead to a situation when we don't clear meta storage properly. And what is the issue with removing unexisting keys in the first place? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.