IGNITE-14428 Formalizes the names of the metrics included in the metric registry. #8937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSAmelchev
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
@ololo3000 , LGTM
@nizhikov , Hi. Could you take a look too, please?
|
@nizhikov Could you confirm please that you are willing to take a look when you will have spare time? |
nizhikov
reviewed
Mar 31, 2021
modules/core/src/main/java/org/apache/ignite/internal/processors/metric/MetricRegistry.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Mar 31, 2021
modules/core/src/test/java/org/apache/ignite/internal/metric/MetricsSelfTest.java
Show resolved
Hide resolved
|
@ololo3000 I left couple of minor comments. Please, fix them prior merge. Thanks for reaching out. |
nizhikov
reviewed
Mar 31, 2021
modules/core/src/main/java/org/apache/ignite/internal/processors/metric/MetricRegistry.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Mar 31, 2021
.../core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/TcpDiscoveryStatistics.java
Show resolved
Hide resolved
|
@nizhikov I have updated PR as we discussed. |
nizhikov
reviewed
Mar 31, 2021
modules/core/src/main/java/org/apache/ignite/internal/processors/metric/MetricRegistry.java
Outdated
Show resolved
Hide resolved
nizhikov
reviewed
Mar 31, 2021
modules/core/src/main/java/org/apache/ignite/internal/processors/metric/impl/MetricUtils.java
Outdated
Show resolved
Hide resolved
|
LGTM. |
nizhikov
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current PR constraints name of the metrics that can be registered through MetricRegistry#register(Metric) - it must start with the name of metric registry it's registered into.
The purpose of this change is to make all metrics that belongs to one MetricRegistry have the name that obeys mentioned above rule regardless how they were registered. It helps to use a consistent approach to work with all metrics.
The following metric names was changed to obey this rule:
JoinedNodes -> io.discovery.JoinedNodes
LeftNodes -> io.discovery.LeftNodes
FailedNodes -> io.discovery.FailedNodes
PendingMessagesRegistered -> io.discovery.PendingMessagesRegistered
CommunicationErrors -> io.discovery.CommunicationErrors
CurrentTopologyVersion -> io.discovery.CurrentTopologyVersion
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.