IGNITE-14699 Add IndexQuery API. #9118

timoninmaxim · 2021-05-21T17:57:22Z

Introduce new public API: Index Query API.

See IEP-71: https://cwiki.apache.org/confluence/display/IGNITE/IEP-71%3A+Public+API+for+secondary+index+search

modules/core/src/main/java/org/apache/ignite/cache/query/IndexQuery.java

...les/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexQueryProcessor.java

modules/core/src/main/java/org/apache/ignite/cache/query/IndexQuery.java

modules/core/src/main/java/org/apache/ignite/cache/query/IndexConditionBuilder.java

alex-plekhanov · 2021-06-16T13:25:03Z

modules/core/src/main/java/org/apache/ignite/internal/cache/query/RangeIndexCondition.java

+        for (int i = 0; i < rngCond.fields.size(); i++) {
+            String f = rngCond.fields.get(i);
+
+            A.ensure(!fields.contains(f), "Duplicated field in conditions: " + f + ".");


Why can't we use the same field twice? For example, if we proceed data month by month a condition would be something like: d >= 01/01/2021 and d < 01/02/2021 and then next query: d >= 01/02/2021 and d < 01/03/2021, etc. With the current implementation, we can't build such conditions (gte and lt on the same field).

I think it's better to add new method with inclusion flags: between(field, lower, upper, lowIncl, upIncl). Otherwise logic could be too hard - how to merge lt and lt, or lt and lte). WDYT?

Discussed privately, decided to provide opportunity to define multiple conditions on the same field and merge them with AND. Will be done in separate ticket.

...les/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexQueryProcessor.java

modules/core/src/main/java/org/apache/ignite/cache/query/IndexQueryCriteria.java

modules/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexProcessor.java

modules/core/src/main/java/org/apache/ignite/cache/query/IndexQuery.java

...e/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryAdapter.java

modules/core/src/main/java/org/apache/ignite/internal/processors/query/GridQueryProcessor.java

modules/indexing/src/test/java/org/apache/ignite/cache/query/IndexQuerySqlIndexTest.java

modules/indexing/src/test/java/org/apache/ignite/cache/query/MultiTableIndexQuery.java

modules/indexing/src/test/java/org/apache/ignite/cache/query/MultifieldIndexQueryTest.java

alex-plekhanov · 2021-06-25T07:20:37Z

Let's also add some test where the index field alias not equal to java field name.

…erion

...les/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexQueryProcessor.java

…ex_queries_api

modules/core/src/main/java/org/apache/ignite/cache/query/IndexQuery.java

...les/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexQueryProcessor.java

modules/core/src/main/java/org/apache/ignite/cache/query/IndexQueryCriteriaBuilder.java

… replace Null class with flags, PriorityQueue for cursors, refactoring.

timoninmaxim · 2021-08-10T12:39:37Z

@AMashenkov I've pushed fixes, could you please have a look?

…ex_queries_api

timoninmaxim · 2021-08-16T10:35:41Z

@AMashenkov hi! I fixed merge conflict. Now, this PR is available for review again.

...les/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexQueryProcessor.java

…elds.

…ex_queries_api

IGNITE-14699 Add IndexQuery API.

659b920

timoninmaxim force-pushed the IGNITE-14699__index_queries_api branch from a0c542f to 659b920 Compare May 21, 2021 18:37

AMashenkov reviewed May 27, 2021

View reviewed changes

modules/core/src/main/java/org/apache/ignite/cache/query/IndexQuery.java Outdated Show resolved Hide resolved

tledkov reviewed May 31, 2021

View reviewed changes

...les/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexQueryProcessor.java Outdated Show resolved Hide resolved

tledkov reviewed May 31, 2021

View reviewed changes

modules/core/src/main/java/org/apache/ignite/cache/query/IndexQuery.java Outdated Show resolved Hide resolved

Rework API. Add condition builder. IndexCondition can merge with others

93d4ec2

timoninmaxim force-pushed the IGNITE-14699__index_queries_api branch from 8a20778 to 93d4ec2 Compare June 10, 2021 19:00

timoninmaxim added 2 commits June 14, 2021 02:01

Add scan step for queries

eac34b2

Remove fail on some illegal conditions

3b3b3ec

alex-plekhanov reviewed Jun 16, 2021

View reviewed changes

timoninmaxim added 4 commits June 17, 2021 10:53

Remove schema name from IndexQuery

804fab8

Check every row on boundaries

83f6f47

Rename conditions to criteria

54f1c72

Refactoring fixes

dd5e285

timoninmaxim force-pushed the IGNITE-14699__index_queries_api branch from 829e857 to dd5e285 Compare June 17, 2021 16:23

Make IndexQueryCriteria immutable

1b80645

alex-plekhanov reviewed Jun 24, 2021

View reviewed changes

timoninmaxim added 2 commits June 29, 2021 17:53

Fix review comments: codestyle, more tests, some fixes

c101c1b

Add test for alias usage

ce1a369

timoninmaxim force-pushed the IGNITE-14699__index_queries_api branch from bc1f6f6 to fc748c5 Compare July 1, 2021 08:21

timoninmaxim added 2 commits July 1, 2021 11:43

Replace complex IndexQueryCriteria with list of single IndexQueryCrit…

a42aba3

…erion

Add alias test

0a065d7

timoninmaxim force-pushed the IGNITE-14699__index_queries_api branch 2 times, most recently from d3850b0 to 2d66613 Compare July 1, 2021 08:52

Do not loop over all indexes to find best match.

76807f2

timoninmaxim force-pushed the IGNITE-14699__index_queries_api branch from 2d66613 to 76807f2 Compare July 1, 2021 08:54

alex-plekhanov approved these changes Jul 2, 2021

View reviewed changes

...les/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexQueryProcessor.java Outdated Show resolved Hide resolved

timoninmaxim added 2 commits July 2, 2021 16:05

Fix misprint

b65ac4f

Merge remote-tracking branch 'upstream/master' into IGNITE-14699__ind…

ceb5de6

…ex_queries_api

AMashenkov requested changes Aug 6, 2021

View reviewed changes

Fix review comments: fix IndexQuery message excetpions, fix javadocs,…

820b096

… replace Null class with flags, PriorityQueue for cursors, refactoring.

timoninmaxim requested a review from AMashenkov August 10, 2021 12:38

timoninmaxim added 2 commits August 16, 2021 12:26

Merge remote-tracking branch 'upstream/master' into IGNITE-14699__ind…

d2a2013

…ex_queries_api

Fix conflict (now use CacheGroupContext instead CacheContext)

5ad86ab

AMashenkov requested a review from tledkov August 17, 2021 12:03

AMashenkov reviewed Aug 26, 2021

View reviewed changes

...les/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexQueryProcessor.java Outdated Show resolved Hide resolved

AMashenkov reviewed Aug 26, 2021

View reviewed changes

...les/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexQueryProcessor.java Show resolved Hide resolved

AMashenkov reviewed Aug 26, 2021

View reviewed changes

...les/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexQueryProcessor.java Outdated Show resolved Hide resolved

AMashenkov reviewed Aug 26, 2021

View reviewed changes

...les/core/src/main/java/org/apache/ignite/internal/cache/query/index/IndexQueryProcessor.java Outdated Show resolved Hide resolved

timoninmaxim added 6 commits August 26, 2021 13:17

Add test for non-existing field in query. Add javadoc for order of fi…

d78d303

…elds.

Support cache value type for build IndexQuery

4157b73

Make index name required for IndexQuery

474bbdc

Merge remote-tracking branch 'upstream/master' into IGNITE-14699__ind…

b47c6d6

…ex_queries_api

Review comments refactoring

59fa4f1

Apply suggestion for rowsIsOutOfRange

89e20ca

AMashenkov approved these changes Sep 14, 2021

View reviewed changes

timoninmaxim added 2 commits September 15, 2021 14:19

Merge remote-tracking branch 'upstream/master' into IGNITE-14699__ind…

5d41388

…ex_queries_api

Add missed javadocs.

543d920

mamadaliev approved these changes Sep 16, 2021

View reviewed changes

AMashenkov merged commit 9cbc585 into apache:master Sep 17, 2021

timoninmaxim deleted the IGNITE-14699__index_queries_api branch September 17, 2021 11:12

xintrian pushed a commit to xintrian/ignite that referenced this pull request May 27, 2022

IGNITE-14699 Add IndexQuery API. (apache#9118)

c07e58b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IGNITE-14699 Add IndexQuery API. #9118

IGNITE-14699 Add IndexQuery API. #9118

timoninmaxim commented May 21, 2021 •

edited

alex-plekhanov Jun 16, 2021

timoninmaxim Jun 17, 2021

timoninmaxim Jun 17, 2021

alex-plekhanov commented Jun 25, 2021

timoninmaxim commented Aug 10, 2021

timoninmaxim commented Aug 16, 2021

IGNITE-14699 Add IndexQuery API. #9118

IGNITE-14699 Add IndexQuery API. #9118

Conversation

timoninmaxim commented May 21, 2021 • edited

alex-plekhanov Jun 16, 2021

Choose a reason for hiding this comment

timoninmaxim Jun 17, 2021

Choose a reason for hiding this comment

timoninmaxim Jun 17, 2021

Choose a reason for hiding this comment

alex-plekhanov commented Jun 25, 2021

timoninmaxim commented Aug 10, 2021

timoninmaxim commented Aug 16, 2021

timoninmaxim commented May 21, 2021 •

edited