Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-14774 Implement metrics for in-memory index pages #9125

Merged
merged 1 commit into from May 26, 2021
Merged

IGNITE-14774 Implement metrics for in-memory index pages #9125

merged 1 commit into from May 26, 2021

Conversation

sashapolo
Copy link
Contributor

@sashapolo sashapolo commented May 24, 2021

Desciption

https://issues.apache.org/jira/browse/IGNITE-14774

  1. PageMetrics - an aggregation of all page-related metrics. At the moment of writing, contains the total number of pages and the number of index pages.
  2. DataRegionMetricsImpl now contains page metrics related to every created cache group in a form of an immutable copy-on-write IntMap. It also contains an aggregation over these metrics that can be used as metrics for the whole data region.
  3. Index pages allocation is tracked through the PageIO#initNewPage method, which can later be used to track other kinds of pages.
  4. Index pages de-allocation is tracked in various places like replacing a page or adding it to a free list as I couldn’t find a single suitable place for this logic.

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@sashapolo sashapolo marked this pull request as ready for review May 24, 2021 18:12
@ibessonov ibessonov merged commit 1b6af49 into apache:master May 26, 2021
@sashapolo sashapolo deleted the ignite-14774 branch May 26, 2021 09:01
xintrian pushed a commit to xintrian/ignite that referenced this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants