Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-15504 .NET: Modernize project structure #9474

Merged
merged 130 commits into from Oct 8, 2021
Merged

IGNITE-15504 .NET: Modernize project structure #9474

merged 130 commits into from Oct 8, 2021

Conversation

ptupitsyn
Copy link
Contributor

@ptupitsyn ptupitsyn commented Oct 6, 2021 •
edited

  • Update all projects (csproj files) to use SDK-style format https://docs.microsoft.com/en-us/dotnet/core/project-sdk/overview#project-files
  • Remove nuspec files, use csproj properties instead.
  • Target netstandard2.0 in modern libraries (Core, Linq, loggers).
  • Target net461 in legacy libraries (EF, ASP.NET).
  • Target netcoreapp3.1 in examples (lowest supported .NET Core version at the moment).
  • Use dotnet CLI to build binaries and packages: this works on any OS, even for legacy Windows-only libraries.
  • Delete legacy NuGet tests.
  • Update build.ps1 - remove complicated logic for nuget and binaries, use simple dotnet CLI commands.

As a result:

  • Nothing should change for the users.
  • Visual Studio is not required.
  • The only requirement is .NET Core SDK 3.1.
  • Build procedure is trivial and works on any OS.
  • Future SDK upgrades are trivial.

@ptupitsyn
Switch libraries to netstandard2.0
99d0b0e
@ptupitsyn
wip
7d2e831
@ptupitsyn
Fix Jvm.CrossAppDomain
984a44c
@ptupitsyn
Fix ServiceProxyTypeGenerator
babdac7
@ptupitsyn
Add Microsoft.Win32.Registry dependency
9c3e0c1
@ptupitsyn
update nuspec dependencies
df4dffb
@ptupitsyn
Fix InternalsVisibleTo - .NET Core build passes
b043b95
@ptupitsyn
Replace unsupported netcoreapp2.0 with netcoreapp3.1
d59d5c8
@ptupitsyn
Remove conditional compilation from libraries
fcbc953
@ptupitsyn
wip fix SslStreamFactory
94a27fb
@ptupitsyn
wip TODO
ee6948b
@ptupitsyn
cleanup
74762d4
@ptupitsyn
Remove legacy projects, create new solution
47885b3
@ptupitsyn
Fix NLog project
58fe120
@ptupitsyn
Fix Apache.Ignite.AspNet.csproj
e218bf9
@ptupitsyn
wip fixing Apache.Ignite.Core.Tests.csproj
d703b44
@ptupitsyn
Fixing Apache.Ignite.csproj
cea4a6d
@ptupitsyn
Fixing Apache.Ignite.csproj
dbbc7d3
@ptupitsyn
Fix Apache.Ignite build
7efcab9
@ptupitsyn
Fix snk link
b230410
@ptupitsyn
wip fixing core tests
1113575
@ptupitsyn
Fixing warnings
f1f7117
@ptupitsyn
Fix tests ruleset
4bcd6c5
@ptupitsyn
Fix log4net project
c8509a3
@ptupitsyn
Add TestDll
91bfe3f
@ptupitsyn
Add TestDll2 with extern alias
6edcea5
@ptupitsyn
Fix log4net reference
9355199
@ptupitsyn
Add missing references
e5b4638
@ptupitsyn
Fix/suppress analysis warnings - build works!
a2046a0
@ptupitsyn
Fix AppDomains logic
b5611db
@ptupitsyn ptupitsyn marked this pull request as ready for review October 7, 2021 10:14
isapego
isapego approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@isapego isapego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ptupitsyn
Fix license, increase JVM heap
47a25b3
@ptupitsyn
Fix client ContinuousQueryTest performance issue due to logging
380919d
@ptupitsyn
Exclude .NET Core specific tests
ca2e458
@ptupitsyn
Disable Java console redirect for Client tests
9e816c5
@ptupitsyn
DataStreamerClientTest cleanup
410dc07
@ptupitsyn
Delete legacy CacheForkedTest.cs
3271c2c
@ptupitsyn
Restore Xmx settings to 6G
d66ad8f
@ptupitsyn
Improve "Failed to process client request" error message
dc13330
@ptupitsyn
Add debug output
7c0958e
@ptupitsyn
Add debug output
f26755a
@ptupitsyn
Increase timeout for CacheGet_NewNodeEnteredTopology_RequestIsRoutedT…
608380c 
…oNewNode
@ptupitsyn
Remove debug output
9472a89
@ptupitsyn
Disable failing tests with a link to IGNITE-15710
496e98f
@ptupitsyn
Fix ServicesTest: rename NodeFilter to NodeIdFilter to avoid clashing…
3c453ac 
… with NUnit NodeFilter class name
@ptupitsyn
Fix TestMultipleDomains
acb617c
@ptupitsyn
Fix PeerAssemblyLoadingTest
bb57bd7
@ptupitsyn
Fix TestIisBehavior
dc43174
@ptupitsyn
Fix TestMultipleVersionsOfSameAssembly, ExecutableTest
6ac4145
@ptupitsyn
Fix examples README
a6c8b28
@ptupitsyn ptupitsyn merged commit 30e6817 into apache:master Oct 8, 2021
@ptupitsyn ptupitsyn deleted the ignite-15504 branch October 8, 2021 10:47
xintrian pushed a commit to xintrian/ignite that referenced this pull request May 27, 2022
@ptupitsyn
IGNITE-15504 .NET: Modernize project structure (apache#9474)
453d1ab 
* Update all projects (csproj files) to use SDK-style format https://docs.microsoft.com/en-us/dotnet/core/project-sdk/overview#project-files
* Remove nuspec files, use csproj properties instead.
* Target netstandard2.0 in modern libraries (Core, Linq, loggers).
* Target net461 in legacy libraries (EF, ASP.NET).
* Target netcoreapp3.1 in examples (lowest supported .NET Core version at the moment).
* Use dotnet CLI to build binaries and packages: this works on any OS, even for legacy Windows-only libraries.
* Delete legacy NuGet tests.
* Update build.ps1 - remove complicated logic for nuget and binaries, use simple dotnet CLI commands.

As a result:
* Nothing should change for the users.
* Visual Studio is not required.
* The only requirement is .NET Core SDK 3.1.
* Build procedure is trivial and works on any OS.
* Future SDK upgrades are trivial.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isapego isapego isapego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ptupitsyn @isapego