Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-16255 Fix WalIterator#lastRead return next record in the middle of iteration #9719

Merged
merged 11 commits into from
Jan 13, 2022

Conversation

nizhikov
Copy link
Contributor

@nizhikov nizhikov commented Jan 11, 2022

StandaloneWalIterator#lastRead pointer updated on advance method and point to the last correctly read record.

advance method read a record that is a step ahead so lastRead points to the next record during iteration
and last record returned by the Iterator#next method in the end of iteration.

This PR makes behavior of the StandaloneWalIterator#lastRead consistent and always point to the last record returned by the Iterator#next method.

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@nizhikov nizhikov changed the title IGNITE-16255 Fix WalIterator return wrong record if lowBound points to the end IGNITE-16255 Fix WalIterator#lastRead return next record in the middle of iteration Jan 12, 2022
@nizhikov
Copy link
Contributor Author

Hello @tkalkirill

Can you, please, take a look at my changes?

@tkalkirill
Copy link
Contributor

Hello @tkalkirill

Can you, please, take a look at my changes?

Hi @nizhikov, I'll take a look today / tomorrow.

@nizhikov nizhikov merged commit b71f826 into apache:master Jan 13, 2022
xintrian pushed a commit to xintrian/ignite that referenced this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants