-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-16255 Fix WalIterator#lastRead return next record in the middle of iteration #9719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nizhikov
changed the title
IGNITE-16255 Fix WalIterator return wrong record if lowBound points to the end
IGNITE-16255 Fix WalIterator#lastRead return next record in the middle of iteration
Jan 12, 2022
Hello @tkalkirill Can you, please, take a look at my changes? |
Hi @nizhikov, I'll take a look today / tomorrow. |
...gnite/internal/processors/cache/persistence/wal/reader/StandaloneWalRecordsIteratorTest.java
Show resolved
Hide resolved
...gnite/internal/processors/cache/persistence/wal/reader/StandaloneWalRecordsIteratorTest.java
Show resolved
Hide resolved
...gnite/internal/processors/cache/persistence/wal/reader/StandaloneWalRecordsIteratorTest.java
Show resolved
Hide resolved
...gnite/internal/processors/cache/persistence/wal/reader/StandaloneWalRecordsIteratorTest.java
Show resolved
Hide resolved
timoninmaxim
approved these changes
Jan 13, 2022
tkalkirill
approved these changes
Jan 13, 2022
xintrian
pushed a commit
to xintrian/ignite
that referenced
this pull request
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StandaloneWalIterator#lastRead
pointer updated onadvance
method and point to the last correctly read record.advance
method read a record that is a step ahead solastRead
points to the next record during iterationand last record returned by the
Iterator#next
method in the end of iteration.This PR makes behavior of the
StandaloneWalIterator#lastRead
consistent and always point to the last record returned by theIterator#next
method.The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summary
whereXXXX
- number of JIRA issue.(see the Maintainers list)
the
green visa
attached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.