Ignite-16685 : Expiration fails on topology version when cluster gets re-activated. V2 - topology version check. #9888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception { | ||
| long time = TimeUnit.SECONDS.toMillis(TIMEOUT_SEC); | ||
|
|
||
| PlatformExpiryPolicyFactory plc = new PlatformExpiryPolicyFactory(time, time, time); |
There was a problem hiding this comment.
This test is not related to platform somehow, please use CreatedExpiryPolicy.factoryOf() or other policy factory.
| */ | ||
| public class ActivationOnExpirationTimeoutTest extends GridCommonAbstractTest { | ||
| /** */ | ||
| private static final int TIMEOUT_SEC = 5; |
There was a problem hiding this comment.
Too much timeout, it takes more than 15 seconds to pass the test (I think 1/2 of second will be enough).
| super.sendMessage(node, msg, ackC); | ||
| } | ||
| }) | ||
| .setFailureHandler(new StopNodeFailureHandler()) |
There was a problem hiding this comment.
If you want to check that failure handler is not triggered, it's better to create own failure handler
| assertEquals(ClusterState.ACTIVE, G.allGrids().get(0).cluster().state()); | ||
| assertEquals(ClusterState.ACTIVE, G.allGrids().get(1).cluster().state()); | ||
|
|
||
| GridTestUtils.waitForCondition(() -> cache.size() == 0, TIMEOUT_SEC); |
There was a problem hiding this comment.
Why? The cluster is just activated. It needs some time to initialize, do PME and permit expiring to work.
| private static final int TIMEOUT_SEC = 5; | ||
|
|
||
| /** */ | ||
| private static final int TOPOLOGY_UPDATE_DELAY_MILLS = 2000; |
| @@ -3106,7 +3106,7 @@ private int purgeExpiredInternal( | |||
| return 0; | |||
|
|
|||
| try { | |||
| if (part != null && part.state() != OWNING) | |||
| if (part == null || !cctx.topology().initialized()) | |||
There was a problem hiding this comment.
Why we don't need check for OWNING state now?
| @@ -82,6 +83,7 @@ | |||
| GridTestUtils.addTestIfNeeded(suite, PageLockTrackerResourcesTest.class, ignoredTests); | |||
|
|
|||
| GridTestUtils.addTestIfNeeded(suite, IgnitePdsCacheEntriesExpirationTest.class, ignoredTests); | |||
| GridTestUtils.addTestIfNeeded(suite, ActivationOnExpirationTimeoutTest.class, ignoredTests); | |||
There was a problem hiding this comment.
ActivationOnExpirationTimeoutTest uses atomic cache, why do we need MVCC test?
| try { | ||
| U.sleep(TOPOLOGY_UPDATE_DELAY_MILLS); | ||
| } | ||
| catch (IgniteInterruptedCheckedException e) { |
| .setCommunicationSpi(new TcpCommunicationSpi() { | ||
| @Override public void sendMessage(ClusterNode node, Message msg, | ||
| IgniteInClosure<IgniteException> ackC) throws IgniteSpiException { | ||
|
|
|
|
||
| return super.getConfiguration(igniteInstanceName) | ||
| .setCommunicationSpi(new TcpCommunicationSpi() { | ||
| @Override public void sendMessage(ClusterNode node, Message msg, |
There was a problem hiding this comment.
Wrong code style (each parameter should be on it's own line)
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.ignite.util; |
alex-plekhanov
approved these changes
Mar 25, 2022
xtern
pushed a commit
to xtern/ignite
that referenced
this pull request
May 5, 2022
…pache#9888. IGNITE-16685 Fix expiration failure on cluster re-activation - Fixes apache#9888. Squashed commit of the following: commit b2c07baeb5992a8be65f6463e1ea42da1088f34f Author: vladsz83 <vladsz83@gmail.com> Date: Fri Mar 25 12:32:45 2022 +0300 IGNITE-16685 Fix expiration failure on cluster re-activation - Fixes apache#9888. Signed-off-by: Aleksey Plekhanov <plehanov.alex@gmail.com> (cherry picked from commit c4d3e5d)
xintrian
pushed a commit
to xintrian/ignite
that referenced
this pull request
May 27, 2022
…pache#9888. Signed-off-by: Aleksey Plekhanov <plehanov.alex@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
Skip partition if topology version isn't initialized additionally to partition state checking (state==OWNING).