IGNITE-16755 C++ Thin: Add user threadpool size to public configuration #9960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptupitsyn
requested changes
Apr 12, 2022
| @@ -743,6 +743,13 @@ namespace ignite | |||
| * @return Number of logical processors. | |||
| */ | |||
| IGNITE_IMPORT_EXPORT uint32_t GetNumberOfProcessors(); | |||
|
|
|||
| /** | |||
| * Get current processor thread count. | |||
There was a problem hiding this comment.
Suggested change
| * Get current processor thread count. | |
| * Get current process thread count. |
| /** | ||
| * Get current processor thread count. | ||
| * | ||
| * @return Current processor thread count. |
There was a problem hiding this comment.
Suggested change
| * @return Current processor thread count. | |
| * @return Current process thread count. |
| @@ -652,6 +653,13 @@ namespace ignite | |||
| * @return Number of logical processors. | |||
| */ | |||
| IGNITE_IMPORT_EXPORT uint32_t GetNumberOfProcessors(); | |||
|
|
|||
| /** | |||
| * Get current processor thread count. | |||
There was a problem hiding this comment.
Suggested change
| * Get current processor thread count. | |
| * Get current process thread count. |
| /** | ||
| * Get current processor thread count. | ||
| * | ||
| * @return Current processor thread count. |
There was a problem hiding this comment.
Suggested change
| * @return Current processor thread count. | |
| * @return Current process thread count. |
| server.PushHandshakeResponse(true); | ||
| server.Start(); | ||
|
|
||
| int32_t threadsBefore = ignite::common::concurrent::GetThreadsCount(); |
There was a problem hiding this comment.
GetThreadsCount is used only for tests, should we keep it in the common module?
xintrian
pushed a commit
to xintrian/ignite
that referenced
this pull request
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IgniteClientConfigurationThe Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.