Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-575] Clarify tutorial and FAQ about schedule_interval always inheriting from DAG object #1402

Merged

Conversation

lauralorenz
Copy link
Contributor

Dear Airflow Maintainers,

Please accept the following PR that

  • Updates the tutorial with a comment helping to explain the use of default_args and
    include all the possible parameters in line
  • Clarifies in the FAQ the possibility of an unexpected default schedule_intervalin case
    airflow users mistakenly try to overwrite the default schedule_interval in a DAG's
    default_args parameter

@lauralorenz
Copy link
Contributor Author

FYI, I couldn't figure out how to change the API reference for BaseSensorOperator to not specify schedule_interval as a parameter on the function signature, since as far as I can tell it isn't in the docstring so I don't know how it is still there. But that might be good to take out too for this point.

@landscape-bot
Copy link

Code Health
Repository health decreased by 1% when pulling a4f8e50 on lauralorenz:schedule_interval_default_args_docs into aecfa7c on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 67.074% when pulling a4f8e506c725fd50f6c12da0f44979a20476ff8b on lauralorenz:schedule_interval_default_args_docs into aecfa7c on airbnb:master.

@artwr
Copy link
Contributor

artwr commented Oct 16, 2016

@lauralorenz This looks good to me, sorry it took us a long time to get to this. I created a JIRA issue for this. https://issues.apache.org/jira/browse/AIRFLOW-575 If you can just have your PR reference this, I will merge it into master.

…ys inheriting from DAG object

- Update the tutorial with a comment helping to explain the use of default_args and
include all the possible parameters in line
- Clarify in the FAQ the possibility of an unexpected default `schedule_interval`in case
airflow users mistakenly try to overwrite the default `schedule_interval` in a DAG's
`default_args` parameter
@lauralorenz lauralorenz force-pushed the schedule_interval_default_args_docs branch from a4f8e50 to 80d3c8d Compare October 17, 2016 16:37
@lauralorenz lauralorenz changed the title Clarify tutorial and FAQ about schedule_interval always inheriting from DAG object [AIRFLOW-575] Clarify tutorial and FAQ about schedule_interval always inheriting from DAG object Oct 17, 2016
@lauralorenz
Copy link
Contributor Author

Woo first real git rebase experience. I rebased with upstream master and amended my commit message to include the JIRA reference. Same with the PR title. I think this is good now, let me know if it needs anything else. @artwr

@asfgit asfgit merged commit 80d3c8d into apache:master Oct 17, 2016
asfgit pushed a commit that referenced this pull request Oct 17, 2016
@artwr
Copy link
Contributor

artwr commented Oct 17, 2016

@lauralorenz Thank you! This has been merged to master.

@lauralorenz
Copy link
Contributor Author

Cool, do I need to do anything to the JIRA issue too?

@artwr
Copy link
Contributor

artwr commented Oct 17, 2016

Just marked it as resolved. Thanks again.

alekstorm pushed a commit to alekstorm/incubator-airflow that referenced this pull request Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants