[AIRFLOW-624] [AIRFLOW-784] [AIRFLOW-785] [AIRFLOW-777] Misc. fixes #2010
Conversation
Current coverage is 66.88% (diff: 50.00%)@@ master #2010 diff @@
==========================================
Files 138 138
Lines 10531 10526 -5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 7046 7040 -6
- Misses 3485 3486 +1
Partials 0 0
|
| @@ -205,7 +205,7 @@ def do_setup(): | |||
| 'flask-login==0.2.11', | |||
| 'flask-swagger==0.2.13', | |||
| 'flask-wtf==0.12', | |||
| 'funcsigs>=1.0.2, <1.1', | |||
There was a problem hiding this comment.
You are setting it lower than we used before.
There was a problem hiding this comment.
Indeed; please check https://issues.apache.org/jira/browse/AIRFLOW-784 why.
There was a problem hiding this comment.
Mmm this ties it to the older version which would downgrade it at some other places. I'm not sure why we were dependent on >= 1.0.2, so I am not too happy by 'just' downgrading. We could also require a higher version of setup tools.
There was a problem hiding this comment.
It's ultimately an issue with funcsigs, I'll open an issue for it.
We could also require a higher version of setup tools.
Afaict the setuptools requirement was what introduced the funcsigs bug for me; doing the same in Airflow would spread the issue more.
| break | ||
|
|
||
| if not dag_is_running: | ||
| if not any(dag_run.state == State.RUNNING for dag_run in dag_runs): |
|
Nice fixes! Small nits / questions. Can you make sure to adhere to the "title" guidelines (mostly your cgroups commit messages is too long). |
cgroups is not a required dependency
gsakkis
changed the title
|
I think you are missing a new line between the title of AIRFLOW0785 and its body. Github shows "..." which means it still exceeds to maximum amount of columns. |
|
Would be nice btw to have a test for AIRFLOW-777 (i.e. covering the function) |
|
There is a new line, I think it's because above the 50 characters limit (59 to be precise). Feel free to suggest an alternative shorter subject but IMHO I'd rather pick a descriptive title than chop it off to to whatever arbitrarily small limit a particular git host uses for display. |
Dear Airflow Maintainers,
Please accept this PR that addresses the following issues: