Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-840] Make ticket renewer python3 compatible #2158

Closed
wants to merge 1 commit into from
Closed

[AIRFLOW-840] Make ticket renewer python3 compatible #2158

wants to merge 1 commit into from

Conversation

abij
Copy link
Contributor

@abij abij commented Mar 16, 2017

The return from the subprocess is in bytes when the universal
newlines is set to False (default). This will fail in Py3 and
works fine in Py2.

Please accept this PR that addresses the following issues:

@mention-bot
Copy link

@abij, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bolkedebruin, @jlowin and @skudriashev to be potential reviewers.

@bolkedebruin
Copy link
Contributor

Let us discuss this when I'm back. You probably need to add an extra User. I think it is a permission problem

@codecov-io
Copy link

codecov-io commented Mar 24, 2017

Codecov Report

Merging #2158 into master will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2158      +/-   ##
==========================================
+ Coverage   67.24%   67.48%   +0.24%     
==========================================
  Files         142      142              
  Lines       10823    10824       +1     
==========================================
+ Hits         7278     7305      +27     
+ Misses       3545     3519      -26
Impacted Files Coverage Δ
airflow/security/kerberos.py 72.09% <100%> (+72.09%) ⬆️
airflow/jobs.py 72.94% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c0f59...7b7140d. Read the comment docs.

@bolkedebruin
Copy link
Contributor

Looks good in general. Are all changes required to setup_kdc.sh? Please also squash your commits into one.

 The return from the subprocess is in bytes when the universal
 newlines is set to False (default). This will fail in Py3 and
 works fine in Py2. And with a working unit test.
@abij
Copy link
Contributor Author

abij commented Mar 28, 2017

Squeezed into single commit and removed some unnecessary bash commands in setup_kdc.sh

@bolkedebruin
Copy link
Contributor

Lgtm!

@asfgit asfgit closed this in 6393366 Mar 28, 2017
alekstorm pushed a commit to alekstorm/incubator-airflow that referenced this pull request Jun 1, 2017
The return from the subprocess is in bytes when
the universal
newlines is set to False (default). This will fail
in Py3 and
works fine in Py2. And with a working unit test.

Closes apache#2158 from abij/AIRFLOW-840
@abij abij deleted the AIRFLOW-840 branch July 4, 2017 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants