Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-1045] Make log level configurable via airflow.cfg #2191

Closed
wants to merge 1 commit into from

Conversation

sekikn
Copy link
Contributor

@sekikn sekikn commented Mar 27, 2017

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR:

For now, changing log level needs to modify settings.py directly.
It's inconvenient. This PR makes it configurable via airflow.cfg.

Tests

  • My PR adds the following unit tests:

core:LogTest

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

For now, changing log level needs to modify settings.py directly.
It's inconvenient. This PR makes it configurable via airflow.cfg.
@mention-bot
Copy link

@sekikn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mistercrunch, @saguziel and @bolkedebruin to be potential reviewers.

@codecov-io
Copy link

codecov-io commented Mar 27, 2017

Codecov Report

Merging #2191 into master will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2191      +/-   ##
=========================================
- Coverage   67.24%   67.2%   -0.05%     
=========================================
  Files         142     142              
  Lines       10823   10833      +10     
=========================================
+ Hits         7278    7280       +2     
- Misses       3545    3553       +8
Impacted Files Coverage Δ
airflow/settings.py 88.88% <66.66%> (-4.07%) ⬇️
airflow/jobs.py 72.94% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c0f59...ec22b63. Read the comment docs.

@bolkedebruin
Copy link
Contributor

Great! LGTM

@asfgit asfgit closed this in e739a5f Mar 28, 2017
alekstorm pushed a commit to alekstorm/incubator-airflow that referenced this pull request Jun 1, 2017
For now, changing log level needs to modify
settings.py directly.
It's inconvenient. This PR makes it configurable
via airflow.cfg.

Closes apache#2191 from sekikn/loglevel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants