Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-1044] base_task_runner fix for Task RUn Ignoring dependencies #2192

Closed
wants to merge 1 commit into from
Closed

Conversation

muthurajr
Copy link

@muthurajr muthurajr commented Mar 27, 2017

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    ignore_task_deps is added to the command formation.
    When "Run" is performed on a task with Ignore Task Debs, its not passed to the command formation and not getting started. Added the same here with ignore_task_deps=local_task_job.ignore_task_deps.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Doesn't need an explicit test case as it adds the missing parameter check.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@mention-bot
Copy link

@muthurajr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aoen and @bolkedebruin to be potential reviewers.

@muthurajr muthurajr changed the title base_task_runner fix for Task RUn Ignoring dependencies [AIRFLOW-1044] base_task_runner fix for Task RUn Ignoring dependencies Mar 27, 2017
@codecov-io
Copy link

codecov-io commented Mar 27, 2017

Codecov Report

Merging #2192 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2192      +/-   ##
==========================================
- Coverage   67.24%   67.23%   -0.01%     
==========================================
  Files         142      142              
  Lines       10823    10823              
==========================================
- Hits         7278     7277       -1     
- Misses       3545     3546       +1
Impacted Files Coverage Δ
airflow/task_runner/base_task_runner.py 71.42% <ø> (ø) ⬆️
airflow/models.py 86.87% <0%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c0f59...4998f1c. Read the comment docs.

@bolkedebruin
Copy link
Contributor

Thank your for your contribution! Please add unit tests - the reason we have this issue, is because we didn't test for it. Although you ticked all the boxes, your commit message does not specify a Jira in the subject line.

… from UI with Ignore Task Debs

ignore_task_deps is added to the command formation.
When "Run" is performed on a task with Ignore Task Debs, its not passed to the command formation and not getting started. Added the same here with ignore_task_deps=local_task_job.ignore_task_deps.
@muthurajr
Copy link
Author

@bolkedebruin Thanks for your feedback and I have updated the commit message!

Will create test case for base_task_runner.py and update them.

@stale
Copy link

stale bot commented Dec 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 10, 2018
@stale stale bot closed this Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants