Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-2240] [dask] Added TLS/SSL support for the dask-distributed scheduler. #2683

Closed
wants to merge 5 commits into from

Conversation

mariusvniekerk
Copy link
Member

As of 0.17.0 dask distributed has support for TLS/SSL.

@codecov-io
Copy link

codecov-io commented Oct 13, 2017

Codecov Report

Merging #2683 into master will increase coverage by 0.55%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2683      +/-   ##
==========================================
+ Coverage   72.98%   73.53%   +0.55%     
==========================================
  Files         180      191      +11     
  Lines       12654    14353    +1699     
==========================================
+ Hits         9235    10555    +1320     
- Misses       3419     3798     +379
Impacted Files Coverage Δ
airflow/executors/dask_executor.py 2% <0%> (-0.33%) ⬇️
airflow/utils/db.py 34.42% <0%> (-2.42%) ⬇️
airflow/configuration.py 82.57% <0%> (-2.41%) ⬇️
airflow/models.py 87.25% <0%> (-0.08%) ⬇️
airflow/settings.py 81.9% <0%> (ø) ⬆️
airflow/exceptions.py 100% <0%> (ø) ⬆️
airflow/www/views.py 71.7% <0%> (ø) ⬆️
airflow/www_rbac/views.py 72.41% <0%> (ø)
airflow/www_rbac/forms.py 100% <0%> (ø)
airflow/www_rbac/utils.py 66.21% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8754cb1...b36d764. Read the comment docs.

@mariusvniekerk
Copy link
Member Author

ping @bolkedebruin

@mrocklin
Copy link

Checking in here. Is there anything blocking this PR?

@artwr
Copy link
Contributor

artwr commented Mar 21, 2018

@mariusvniekerk LGTM, a test would be nice though.
Could you also change your commit to mention the JIRA number associated with it?

@mariusvniekerk mariusvniekerk changed the title [dask] Added TLS/SSL support for the dask-distributed scheduler. [AIRFLOW-2240] [dask] Added TLS/SSL support for the dask-distributed scheduler. Mar 21, 2018
@mariusvniekerk
Copy link
Member Author

Updated title

@mrocklin
Copy link

@mariusvniekerk Dask has some testing infrastructure to set up a local cluster with TLS active. See example here: https://github.com/dask/distributed/blob/master/distributed/tests/test_tls_functional.py#L23

@artwr
Copy link
Contributor

artwr commented Mar 22, 2018

We'll wait until CI passes, but looks good to me +1

@mariusvniekerk
Copy link
Member Author

@artwr ping

@artwr
Copy link
Contributor

artwr commented Apr 18, 2018

LGTM, thank you!

@asfgit asfgit closed this in e95a125 Apr 18, 2018
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
…cheduler.

As of 0.17.0 dask distributed has support for
TLS/SSL.

[dask] Added TLS/SSL support for the dask-
distributed scheduler.

As of 0.17.0 dask distributed has support for
TLS/SSL.

Add a test for tls under dask distributed

Closes apache#2683 from mariusvniekerk/dask-ssl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants