-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-2240] [dask] Added TLS/SSL support for the dask-distributed scheduler. #2683
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2683 +/- ##
==========================================
+ Coverage 72.98% 73.53% +0.55%
==========================================
Files 180 191 +11
Lines 12654 14353 +1699
==========================================
+ Hits 9235 10555 +1320
- Misses 3419 3798 +379
Continue to review full report at Codecov.
|
38e38a0
to
01a0cd2
Compare
ping @bolkedebruin |
Checking in here. Is there anything blocking this PR? |
@mariusvniekerk LGTM, a test would be nice though. |
Updated title |
@mariusvniekerk Dask has some testing infrastructure to set up a local cluster with TLS active. See example here: https://github.com/dask/distributed/blob/master/distributed/tests/test_tls_functional.py#L23 |
As of 0.17.0 dask distributed has support for TLS/SSL.
24635cb
to
1e6a7bd
Compare
1e6a7bd
to
b317baa
Compare
We'll wait until CI passes, but looks good to me +1 |
@artwr ping |
LGTM, thank you! |
…cheduler. As of 0.17.0 dask distributed has support for TLS/SSL. [dask] Added TLS/SSL support for the dask- distributed scheduler. As of 0.17.0 dask distributed has support for TLS/SSL. Add a test for tls under dask distributed Closes apache#2683 from mariusvniekerk/dask-ssl
As of 0.17.0 dask distributed has support for TLS/SSL.