Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-1816] Add missing region param to Dataproc{Pig,Hive,SparkSql}Operators #2788

Closed
wants to merge 1 commit into from

Conversation

DanSedov
Copy link
Contributor

@DanSedov DanSedov commented Nov 14, 2017

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Add missing region param to Dataproc{Pig,Hive,SparkSql}Operators

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@DanSedov DanSedov changed the title [AIRFLOW-1816] Add missing region param to several DataprocOperator jobs [AIRFLOW-1816] Add missing region param to Dataproc{Pig,Hive,SparkSql}Operators Nov 14, 2017
@Fokko
Copy link
Contributor

Fokko commented Nov 15, 2017

Could you please rewrite the commit message, please refer to the rules in the PR template.

@DanSedov
Copy link
Contributor Author

Done

@codecov-io
Copy link

codecov-io commented Nov 15, 2017

Codecov Report

Merging #2788 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2788     +/-   ##
=========================================
+ Coverage   73.36%   73.46%   +0.1%     
=========================================
  Files         157      157             
  Lines       11935    11935             
=========================================
+ Hits         8756     8768     +12     
+ Misses       3179     3167     -12
Impacted Files Coverage Δ
airflow/jobs.py 79.67% <0%> (+0.44%) ⬆️
airflow/executors/dask_executor.py 81.39% <0%> (+2.32%) ⬆️
airflow/utils/helpers.py 56.32% <0%> (+2.87%) ⬆️
airflow/task_runner/bash_task_runner.py 100% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5157b5a...d2bbbda. Read the comment docs.

@criccomini
Copy link
Contributor

LGTM

@asfgit asfgit closed this in d04519e Nov 15, 2017
Acehaidrey pushed a commit to Acehaidrey/incubator-airflow that referenced this pull request Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants