[AIRFLOW-1850] Copy cmd before masking #2817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cmd is first copied before the password is masked. This ensures that the orignal cmd isn't changed. Replacing the password with a masked value replaces the password in the original command since it is passed by reference.
Codecov Report
@@ Coverage Diff @@
## master #2817 +/- ##
=======================================
Coverage 73.62% 73.62%
=======================================
Files 158 158
Lines 11962 11962
=======================================
Hits 8807 8807
Misses 3155 3155Continue to review full report at Codecov.
|
|
Lgtm |
ghost
pushed a commit
to RealImpactAnalytics/airflow
that referenced
this pull request
Dec 7, 2017
The cmd is first copied before the password is masked. This ensures that the orignal cmd isn't changed. Replacing the password with a masked value replaces the password in the original command since it is passed by reference. Closes apache#2817 from Fokko/AIRFLOW-1850-copy-cmd- before-replacing-password
Acehaidrey
pushed a commit
to Acehaidrey/incubator-airflow
that referenced
this pull request
Jan 19, 2018
The cmd is first copied before the password is masked. This ensures that the orignal cmd isn't changed. Replacing the password with a masked value replaces the password in the original command since it is passed by reference. Closes apache#2817 from Fokko/AIRFLOW-1850-copy-cmd- before-replacing-password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
The cmd is first copied before the password is masked. This ensures
that the orignal cmd isn't changed. Replacing the password with a
masked value replaces the password in the original command since it
is passed by reference.
JIRA
Description
Tests
Commits