[AIRFLOW-1879] Handle ti log entirely within ti #2837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously logging was setup outside a TaskInstance, this puts everything inside. Also propery closes the logging.
ashb
reviewed
Dec 2, 2017
|
|
||
| hostname = socket.getfqdn() | ||
| log.info("Running on host %s", hostname) | ||
| log.info("Running %s on host %s", ti, hostname) |
There was a problem hiding this comment.
Oh maybe not. I thought log wasn't a local variable anymore but tests pass so :)
There was a problem hiding this comment.
log is actually a local variable as well. I thought it made more sense to log in that facility rather than 'hijack' the TI log.
Codecov Report
@@ Coverage Diff @@
## master #2837 +/- ##
==========================================
- Coverage 74.01% 73.94% -0.07%
==========================================
Files 159 159
Lines 12076 12075 -1
==========================================
- Hits 8938 8929 -9
- Misses 3138 3146 +8
Continue to review full report at Codecov.
|
|
@Fokko PTAL |
|
I like it, we don't want any logging logic inside of the cli class. |
ghost
pushed a commit
to RealImpactAnalytics/airflow
that referenced
this pull request
Dec 7, 2017
Previously logging was setup outside a TaskInstance, this puts everything inside. Also propery closes the logging. Closes apache#2837 from bolkedebruin/AIRFLOW-1879
Acehaidrey
pushed a commit
to Acehaidrey/incubator-airflow
that referenced
this pull request
Jan 19, 2018
Previously logging was setup outside a TaskInstance, this puts everything inside. Also propery closes the logging. Closes apache#2837 from bolkedebruin/AIRFLOW-1879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
JIRA
Description
Previously logging was setup outside a TaskInstance,
this puts everything inside. Also propery closes
the logging.
Tests
Covered by current tests.
Commits
My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
Passes
git diff upstream/master -u -- "*.py" | flake8 --diffcc: @ashb @Fokko @jgao54