Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-1938] Remove tag version check in setup.py #2889

Closed
wants to merge 1 commit into from
Closed

[AIRFLOW-1938] Remove tag version check in setup.py #2889

wants to merge 1 commit into from

Conversation

criccomini
Copy link
Contributor

Make sure you have checked all steps below.

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@mylons
Copy link
Contributor

mylons commented Dec 18, 2017

yay.

@Fokko
Copy link
Contributor

Fokko commented Dec 19, 2017

Can you explain the why?

@bolkedebruin
Copy link
Contributor

@Fokko it is a kind of runtime check that doesnt really seem to make sense

@criccomini
Copy link
Contributor Author

@Fokko it also just doesn't work with the apache release process. See description in JIRA.

@bolkedebruin
Copy link
Contributor

LGTM

@criccomini
Copy link
Contributor Author

Merged!

@asfgit asfgit closed this in cc4404b Dec 19, 2017
Acehaidrey pushed a commit to Acehaidrey/incubator-airflow that referenced this pull request Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants