Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-2248] Fix wrong param name in RedshiftToS3Transfer doc #3156

Merged
merged 1 commit into from
Mar 24, 2018

Conversation

sekikn
Copy link
Contributor

@sekikn sekikn commented Mar 24, 2018

Make sure you have checked all steps below.

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:

The parameter 'unload_options' is wrongly referred to as 'options'
in the RedshiftToS3Transfer docstring. This PR fixes it.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

This PR does not need testing since it's documentation fix. I ran docs/build.sh locally and confirmed the document is generated as expected.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

The parameter 'unload_options' is wrongly referred to as 'options'
in the RedshiftToS3Transfer doc. This PR fixes it.
@asfgit asfgit merged commit a7a771f into apache:master Mar 24, 2018
asfgit pushed a commit that referenced this pull request Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants