New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-2509] Separate config docs into how-to guides #3400
Conversation
Also moves how-to style instructions for logging from "integration" page to a "Writing Logs" how-to.
Travis failure appears to be unrelated to this change (permissions error on installing a package). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good improvement. +1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @tswast for this PR. The documentation changes are always very important. Appreciate that. |
@tswast Can you update the documentation here to say that you can also create connections using the Airflow Web UI which is much easy and intuitive as compared to environment variables method and also point to the specific link of creating connection (see here ) instead of linking it to the concepts section? Or instead of 2 separate pages i.e 1) Securing connections, and 2) Creating connections: I think a single page Creating and Securing connections would make more sense. What do you think about it @tswast? |
@kaxil Yes, updating the connection page is the next thing I want to work on. Web UI instructions are a good idea. I actually would like to have space to talk about all the specific connection types on the creating a connection page. The PostgreSQL example you link to would be a good one to add. Selfishly, I'd also like to document how to create a GCP connection soon, too. It could make sense to combine the creating and securing pages, but securing them felt like a very different task from creating one, which is why I split them up. |
Also moves how-to style instructions for logging from "integration" page to a "Writing Logs" how-to. Closes apache#3400 from tswast/howto
Also moves how-to style instructions for logging from "integration" page
to a "Writing Logs" how-to.
Make sure you have checked all steps below.
JIRA
Description
Splits Configuration documentation into separate how-to guides, much as the Django documentation does.
Tests
No tests. Docs-only change.
Commits
Documentation
Docs-only change.
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff