[AIRFLOW-2795] Oracle to Oracle Transfer Operator #3639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3639 +/- ##
==========================================
- Coverage 77.51% 77.17% -0.35%
==========================================
Files 205 206 +1
Lines 15751 15769 +18
==========================================
- Hits 12210 12169 -41
- Misses 3541 3600 +59
Continue to review full report at Codecov.
|
| @apply_defaults | ||
| def __init__( | ||
| self, | ||
| oracle_destination_conn_id, |
There was a problem hiding this comment.
The source and destination differ in order in the docstring/arguments
| oracle_destination_conn_id, | ||
| destination_table, | ||
| oracle_source_conn_id, | ||
| source_sql, |
There was a problem hiding this comment.
This is called sql in the docstring
| cursor = src_conn.cursor() | ||
| self.log.info("Querying data from source: {0}".format( | ||
| self.oracle_source_conn_id)) | ||
| cursor.execute(self.source_sql, self.source_sql_params) |
There was a problem hiding this comment.
Ideally we would like to template the sql using the ninja2 templating engine. Why would we need the extra params? Note: I'm not an Oracle expert :-)
There was a problem hiding this comment.
Hi @Fokko , both source_sql and source_sql_params are templated fields. The reason to use extra params is because in some DBAPI, special characters are only considered when passed using parameters.
marcusrehm
force-pushed
the
oracle_to_oracle_transfer
branch
3 times, most recently
from
81999b0
to
7971332
Compare
marcusrehm
force-pushed
the
oracle_to_oracle_transfer
branch
from
7971332
to
6c0720e
Compare
|
Just bumping up |
Make sure you have checked all steps below.
JIRA
Description
Tests
Commits
Documentation
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff