[AIRFLOW-2846] Add missing python test dependency to setup.py

[holdenk]

Add missing python test dependency (tox) to setup.py dev requirement.

Make sure you have checked all steps below.

Jira

• [ X ] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-2846] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-2846

Description

• Here are some details about my PR, including screenshots of any UI changes:

Tests

• [ X ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
  Adds test dependency.

Commits

• [ X ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

• [ X ] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

[ashb]

Could you rebase please?

[tedmiston]

Good catch. I'm not sure how we made it this long without tox in there.

I happen to install it system-wide with pipsi... I wonder if everyone else just happens to do something similar, or maybe they're running the dockerized tests setup, or maybe they're just not running against tox locally? I wonder if there's room for us to make that clearer in the docs? I'm not sure if we consider one of these a best practice more than the others.

[ashb]

I both have it installed globally, and don’t run with tox locally because the full test suite non-parallel takes a looong time, so I run individual test suites usually.

[feng-tao]

need to rebase.

[Fokko]

In case who missed it: https://www.youtube.com/watch?v=5Il3w2P7IcM Awesome work @holdenk for getting people inspired to contribute to open source software!

I've checked. The tox version being installed with apt-get by Travis is also 3.1.3. Not completely sure why this failed :-)
In the end we should rely less on Travis and move to a Dockerized setup to make testing easier. There is a great effort going on in #3393 but there are still some lose ends that need to be fixed before we can merge it.

[holdenk]

Thank y'all for the review and kind words, I've rebased on master.

[r39132]

Build failures look unrelated! Retriggering build.. let's see.

[r39132]

This is bizarre, retriggering the build/test caused it to fail the same files. @holdenk TravisCI pass on your fork? If so, let me know.

[Fokko]

I'd say that we would need to remove this tox install as well: https://github.com/apache/incubator-airflow/blob/master/.travis.yml#L98

[r39132]

@holdenk can you look at @Fokko suggestion, which I interpret as removing the tox from travis.yml but leaving it in setup.py in order to let the tests pass.

[r39132]

@holdenk friendly ping.. if this is not needed anymore, we can consider closing it.

[holdenk]

Sorry about this, had some work stuff happen but got more cycles for airlfow again, I'll update this now.

[holdenk]

The more I look at this the less sense it makes, requiring tox shouldn't cause these sorts of failures.

[ashb]

The failures do look totally unrelated to Tox or not. Given we have dockeriszed the CI and test pipelines do we need even tox anymore?

[Fokko]

@ashb I'm working on removing tox, but removing tox this isn't trivial. Since we already encapsulate the tests in Docker, tox adds another layer of abstraction, which is not required in my opinion.

[holdenk]

With the new dockerized test enviroment I don't think we need this PR anymore. I'll close it for now and switch the JIRA to Won't Fix. If folks disagree feel free to re-open it :)