Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-2428] Add AutoScalingRole key to emr_hook #3713

Closed
wants to merge 1 commit into from

Conversation

dmnpignaud
Copy link

Jira

Description

  • Enable the use of the autoscaling functionality when creating an EMR cluster

Tests

  • None

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@@ -63,6 +63,8 @@ def create_job_flow(self, job_flow_overrides):
VisibleToAllUsers=config.get('VisibleToAllUsers'),
JobFlowRole=config.get('JobFlowRole'),
ServiceRole=config.get('ServiceRole'),
AutoScalingRole=config.get('AutoScalingRole'),
ScaleDownBehavior=config.get('ScaleDownBehavior'),
Tags=config.get('Tags')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I wonder if it might be an idea to do self.get_conn().run_job_flow(**config) - that we don't have to stay up-to-date with the AWS API.

For that to work we'd need three config.setdefault() calls for the three list-types. I also don't know if all the kwargs are optional or not (but I suspect they are).

@stale
Copy link

stale bot commented Dec 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 10, 2018
@stale stale bot closed this Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants