Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[AIRFLOW-2878] Fix www_rbac display issue" #3734

Closed
wants to merge 1 commit into from

Conversation

XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented Aug 10, 2018

Hi @r39132 , this is to revert my earlier PR #3724.

As pointed out by @verdan , I encountered the issues that I tried to fix in my earlier PR because I didn't build the frontend packages using npm and webpack. That commit may also introduce extra spaces in each page.

Please refer to my conversation with Verdan in PR #3724.

Sorry for the inconvenience cause, and thanks @verdan for having pointed this out.

@feng-tao
Copy link
Member

I don't think we need another pull request. We directly revert the original request. I will do that.

@XD-DENG
Copy link
Member Author

XD-DENG commented Aug 10, 2018

Thanks @feng-tao

@XD-DENG XD-DENG closed this Aug 10, 2018
@feng-tao feng-tao reopened this Aug 10, 2018
@feng-tao feng-tao closed this Aug 10, 2018
@feng-tao
Copy link
Member

@XD-DENG , I think directly revertting your pr in github may revert other prs that get merged after yours. But never mind, I will take care of that. Thanks.

@XD-DENG
Copy link
Member Author

XD-DENG commented Aug 10, 2018

@feng-tao Or may I trouble you to do a separate commit to remove the three lines I added? i.e. it's actually reverting the changes made in my earlier PR but doesn't touch other PRs?

Thanks for taking care of this, and sorry for the inconvenience caused.

@feng-tao
Copy link
Member

@XD-DENG , will do.

@XD-DENG XD-DENG deleted the revert-3724-patch-2 branch August 13, 2018 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants